net, gui: -upnp option – “override” vs “can be changed on-the-fly” #18184

1. 
   hebasto commented at 10:20 am on February 20, 2020: member

   On master (68e841e0af223a220d1f037e4c5680c1b228aa3e) the -upnp option being set in the command line or in the configuration file overrides the GUI option only on startup.

   If a user (un)checks the “Map port using UPnP” checkbox in the “Network” tab of the “Options” window, the client does not take into account the fact that the -upnp option is set in the command line or in the configuration file.

   There some ways to resolve an issue:

   • document the current behavior
   • deactivate the “Map port using UPnP” checkbox if the -upnp option is set in the command line or in the configuration file
   • smth else

   The brainstorm question is which way is the best?

   ---

   This issue was initially raised by luke-jr in his review of #18077.

2. fanquake added the label P2P on Feb 20, 2020
3. fanquake added the label Brainstorming on Feb 20, 2020
4. 
   fanquake commented at 2:03 pm on February 7, 2023: member

   This looks like it’s a GUI-only issue? So I think this should be moved to the GUI repository.
5. 
   fanquake commented at 2:55 pm on February 7, 2023: member

   Moved to https://github.com/bitcoin-core/gui/issues/710.
6. fanquake closed this on Feb 7, 2023

   ---

7. bitcoin locked this on Feb 7, 2024

Contributors
hebasto fanquake

Labels
Brainstorming P2P