test: Reduce unneeded whitelist permissions in tests #18209
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2002-qaLimitWhitelist changing 12 files +31 −22-
MarcoFalke commented at 4:58 pm on February 25, 2020: memberIt makes the tests confusing and fragile when overwriting default command line values that are not needed to be overwritten.
-
test: Reduce unneeded whitelist permissions in tests fa45d60646
-
MarcoFalke force-pushed on Feb 25, 2020
-
DrahtBot added the label Tests on Feb 25, 2020
-
Sjors commented at 7:44 pm on February 25, 2020: memberConcept ACK for making the whitelist permissions more precise.
-
MarcoFalke commented at 7:47 pm on February 25, 2020: member
Concept ACK for making the whitelist permissions more precise.
Only in the tests, I will leave it to someone else to change them in Bitcoin Core ;)
-
DrahtBot commented at 10:25 pm on February 25, 2020: member
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #17959 (test: check specific reject reasons in feature_csv_activation.py by theStack)
- #17921 (test: test OP_CSV empty stack fail in feature_csv_activation.py by theStack)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
-
laanwj commented at 5:42 pm on February 26, 2020: memberACK fa45d606461dbf5bf1017d6ab15e89c1bcf821a6
-
fanquake approved
-
fanquake commented at 4:31 am on February 28, 2020: memberACK fa45d606461dbf5bf1017d6ab15e89c1bcf821a6
-
fanquake merged this on Feb 28, 2020
-
fanquake closed this on Feb 28, 2020
-
sidhujag referenced this in commit 3a4e26e1e7 on Feb 28, 2020
-
MarcoFalke deleted the branch on Feb 28, 2020
-
sidhujag referenced this in commit 60c13db467 on Nov 10, 2020
-
deadalnix referenced this in commit 3f7a57ff8c on Jan 5, 2021
-
DrahtBot locked this on Feb 15, 2022
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-06-01 22:13 UTC
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-06-01 22:13 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me