[0.19] Further 0.19 backports #18218

1. 
   fanquake commented at 4:13 AM on February 28, 2020: member

   These are not blockers for the 0.19.1 release, as per IRC discussion this morning, doesn't look like there will be an rc3. This PR can collect further backports for the 0.19 branch.

   Currently backports:

   • #18004 - build: don't embed a build-id when building libdmg-hfsplus
   • #18123 - gui: Fix race in WalletModel::pollBalanceChanged
2. build: don't embed a build-id when building libdmg-hfsplus

   Github-Pull: #18004
   Rebased-From: cb9e88e73a042ff4e1c83289a6f8fa1db03fb093

   1964561a3a
3. gui: Fix race in WalletModel::pollBalanceChanged

   Poll function was wrongly setting cached height to the current chain height
   instead of the chain height at the time of polling.
   
   This bug could cause balances to appear out of date, and was first introduced
   https://github.com/bitcoin/bitcoin/pull/10244/commits/a0704a8996bb950ae3c4d5b5a30e9dfe34cde1d3#r378452145
   Before that commit, there wasn't a problem because cs_main was held during the
   poll update.
   
   Currently, the problem should be rare. But if
   8937d99ce81a27ae5e1012a28323c0e26d89c50b from #17954 were merged, the problem
   would get worse, because the wrong cachedNumBlocks value would be set if the
   wallet was polled in the interval between a block being connected and it
   processing the BlockConnected notification.
   
   MarcoFalke <falke.marco@gmail.com> also points out that a0704a8996b could lead
   to GUI hangs as well, because previously the pollBalanceChanged method, which
   runs on the GUI thread, would only make a nonblocking TRY_LOCK(cs_main) call,
   but after could make blocking LOCK(cs_main) calls, potentially locking up the
   GUI.
   
   Thanks to John Newbery <john@johnnewbery.com> for finding this bug this while
   reviewing https://github.com/bitcoin/bitcoin/pull/17954.
   
   Github-Pull: #18123
   Rebased-From: bf36a3ccc212ad4d7c5cb8f26d7a22e279fe3cec

   48fef5ebae
4. fanquake added the label Backport on Feb 28, 2020
5. fanquake added this to the milestone 0.19.2 on Feb 28, 2020
6. 
   promag commented at 12:25 AM on March 2, 2020: member

   ACK 48fef5ebae58b0730619182007218941bd339768.

7. 
   laanwj commented at 4:01 PM on March 2, 2020: member

   ACK 48fef5ebae58b0730619182007218941bd339768

8. 
   luke-jr commented at 3:03 PM on March 4, 2020: member

   utACK 48fef5ebae58b0730619182007218941bd339768

9. MarcoFalke merged this on Mar 4, 2020
10. MarcoFalke closed this on Mar 4, 2020

    ---

11. fanquake deleted the branch on Mar 5, 2020
12. MarkLTZ referenced this in commit ece88bae51 on Mar 13, 2020
13. DrahtBot locked this on Feb 15, 2022

Milestone
0.19.2