Make AnalyzePSBT next role calculation simple, correct #18224

pull instagibbs wants to merge 1 commits into bitcoin:master from instagibbs:analyze_psbt_role_simple changing 2 files +15 −20

instagibbs commented at 4:28 PM on February 28, 2020: member
Sniped test and alternative to #18220

Sjors documenting the issue:
```
A PSBT signed by ColdCard was analyzed as follows (see [#17509](/bitcoin-bitcoin/17509/) (comment))

{
  "inputs": [
    {
      "has_utxo": true,
      "is_final": false,
      "next": "finalizer"
    }
  ],
  "estimated_vsize": 141,
  "estimated_feerate": 1e-05,
  "fee": 1.41e-06,
  "next": "signer"
}
I changed AnalyzePSBT so that it returns "next": "finalizer" instead.
```
It makes it much clearer that the role has been decided before hitting the calc_fee block, and groups all state-deciding in one spot instead of 2.

Note that this assumes that PSBT roles are a complete ordering, which for now and in the future seems to be a correct assumption.
Make AnalyzePSBT next role calculation simple, correct 1ef28b4f7c
instagibbs force-pushed on Feb 28, 2020
Sjors commented at 4:33 PM on February 28, 2020: member

ACK 1ef28b4f7cfba410fef524def1dac24bbc4086ca, much nicer. Don't forget to document the bug fix.
instagibbs commented at 4:36 PM on February 28, 2020: member

@achow101 poing
achow101 commented at 5:41 PM on February 28, 2020: member

ACK 1ef28b4f7cfba410fef524def1dac24bbc4086ca
DrahtBot added the label Tests on Feb 28, 2020
Empact commented at 7:36 PM on February 28, 2020: member

ACK https://github.com/bitcoin/bitcoin/pull/18224/commits/1ef28b4f7cfba410fef524def1dac24bbc4086ca
fanquake added the label PSBT on Feb 28, 2020
DrahtBot commented at 10:21 PM on February 28, 2020: member



The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

No conflicts as of last run.
meshcollider merged this on Mar 2, 2020
meshcollider closed this on Mar 2, 2020
sidhujag referenced this in commit 24a43a9ab0 on Mar 2, 2020
luke-jr referenced this in commit eda8c7ed5a on Mar 5, 2020
sidhujag referenced this in commit eaf7646859 on Nov 10, 2020
DrahtBot locked this on Feb 15, 2022

Contributors

Labels

Linked (view graph)

#17509 gui: save and load PSBT #18220 psbt: AnalyzePSBT set next to"finalizer" when all inputs need finalizing

Make AnalyzePSBT next role calculation simple, correct #18224

Conflicts