refactor: Consolidate unnecessary base58 interfaces #18226

pull Empact wants to merge 2 commits into bitcoin:master from Empact:2020-02-base58 changing 5 files +25 −59
  1. Empact commented at 7:25 PM on February 28, 2020: member

    Four of the seven base58 declarations are strictly unnecessary.

    Note there are randomly generated test calls to DecodeBase58Check that would violate the unenforced max_ret_len > 0 expectation of that function, but not the effective max_ret_len + 4 > 0 assertion enforced here.

  2. fanquake added the label Refactoring on Feb 28, 2020
  3. refactor: Consolidate unnecessary base58 interfaces
    Three of these seven interfaces are functionally unused, removing them
simplifies the codebase.
    b29bd328e8
  4. Assert against invalid args to DecodeBase58 464bee876e
  5. Empact force-pushed on Feb 28, 2020
  6. DrahtBot commented at 10:19 PM on February 28, 2020: member

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #18011 (Replace current benchmarking framework with nanobench by martinus)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  7. Empact commented at 10:33 PM on February 28, 2020: member

    Meh

  8. Empact closed this on Feb 28, 2020
  9. DrahtBot locked this on Feb 15, 2022
Contributors
EmpactDrahtBot
Labels
Refactoring
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-22 06:14 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me