WIP test: Check that wait_until returns if time point is in the past #18232

pull MarcoFalke wants to merge 7 commits into bitcoin:master from MarcoFalke:2002-debugBoost changing 3 files +22 −4

MarcoFalke commented at 8:57 PM on February 29, 2020: member

Regression test for https://github.com/boostorg/thread/issues/308
test: Check that wait_until returns if time point is in the past fa6bad251d
DrahtBot added the label Tests on Feb 29, 2020
MarcoFalke commented at 3:10 PM on March 1, 2020: member

The unit test currently fails fails when using boost from depends on Linux
DrahtBot commented at 3:40 PM on March 1, 2020: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #17941 (depends: update to Boost 1.72 by Sjors)
- #16549 ([WIP] UI external signer support (e.g. hardware wallet) by Sjors)
- #16546 ([WIP] External signer support - Wallet Box edition by Sjors)
- #16367 (Multiprocess build support by ryanofsky)
- #15382 (util: add runCommandParseJSON by Sjors)
- #10102 ([experimental] Multiprocess bitcoin by ryanofsky)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
[depends] update to Boost 1.72 6b4d598af3
MarcoFalke force-pushed on Mar 1, 2020
MarcoFalke force-pushed on Mar 1, 2020
depends: Set boost version to 1.58 163739149b
MarcoFalke force-pushed on Mar 1, 2020
[depends] Boost 1.64.0 0f2815bc2f
depends: Set boost to 1.67 e1c7598fe2
depends: Set boost to 1.66 7ac48612e2
depends: Set boost to 1.65 3eca9ca493
luke-jr commented at 4:26 PM on March 4, 2020: member

??? Why is this downgrading boost, and documenting it as upgraded?
luke-jr commented at 4:31 PM on March 4, 2020: member

If this bug affects us with all recent boost versions (at least <=1.66 are not available in Gentoo anymore), maybe we should implement a workaround instead?
MarcoFalke renamed this:
~~test: Check that wait_until returns if time point is in the past~~
WIP test: Check that wait_until returns if time point is in the past
on Mar 4, 2020
MarcoFalke commented at 5:24 PM on March 4, 2020: member

I think there is nothing we can do here except to remove boost
MarcoFalke closed this on Mar 4, 2020
MarcoFalke deleted the branch on Mar 4, 2020
luke-jr commented at 5:30 PM on March 4, 2020: member

Utility function to check for the exception and see if the time passed explicitly?
MarcoFalke locked this on Feb 15, 2022

Contributors

Labels

WIP test: Check that wait_until returns if time point is in the past #18232

Conflicts