I wanted to open an issue to understand why bnb_search as implemented @achow101 does not terminate once an optimal search is found. This behavior is evident I believe when inspecting the test which sets the target to 5 and uses the utxo pool 4,3,2,1. since combinations of 4 are evaluated first, the bnb_search finds an optimal solution of 4,1. However, instead of terminating when the best_waste = 0 (no better solution can be found), the search continues and instead finds another solution 2,3 which also has a best_waste = 0. Why not terminate once an optimal solution is found instead of continuing to search?
-
yancyribbens commented at 7:58 AM on March 4, 2020: contributor
- laanwj added the label Wallet on Mar 4, 2020
- laanwj assigned achow101 on Mar 4, 2020
-
practicalswift commented at 11:08 PM on March 4, 2020: contributor
@yancyribbens Excellent find! Hope we'll see more contributions from you in the future :)
- meshcollider closed this on Apr 17, 2020
- sidhujag referenced this in commit 87fa1c591a on Apr 17, 2020
- ComputerCraftr referenced this in commit 7c27e96ed3 on Jun 10, 2020
- PastaPastaPasta referenced this in commit f134a068f0 on Sep 17, 2021
- PastaPastaPasta referenced this in commit 421fcde34d on Sep 17, 2021
- PastaPastaPasta referenced this in commit aaf2a17767 on Sep 18, 2021
- thelazier referenced this in commit ac01d4b41f on Sep 25, 2021
- DrahtBot locked this on Feb 15, 2022