test: add option to functional test_runner to adjust test timeouts #18266

1. 
   fanquake commented at 7:07 am on March 5, 2020: member

   It was suggested that we could have an additional argument for the functional test_runner that modifies the timeouts by some factor. This would save having to randomly bump timeouts in the tests themselves, as users that require longer timeouts can opt in by -factor=1.5 etc.

   Follow up to #18249.

   Want to work on this issue?

   The purpose of the good first issue label is to highlight which issues are suitable for a new contributor without a deep understanding of the codebase.

   You do not need to request permission to start working on this. You are encouraged to comment on the issue if you are planning to work on it. This will help other contributors monitor which issues are actively being addressed and is also an effective way to request assistance if and when you need it.

   For guidance on contributing, please read CONTRIBUTING.md before opening your pull request.

2. fanquake added the label Tests on Mar 5, 2020
3. fanquake added the label good first issue on Mar 5, 2020
4. 
   modfort commented at 1:21 am on March 19, 2020: none

   I would like to work on this .
5. 
   MarcoFalke commented at 12:52 pm on March 19, 2020: member

   To find the timeouts that need to be reworked:

   0git grep 'def ' test/functional/test_framework/ | grep 'timeout='
   1
   2git grep 'self.rpc_timeout = 60' test/functional/test_framework/
   

6. 
   modfort commented at 12:00 pm on April 8, 2020: none

   Hi , if you can help with a problem in configure , configure: error: LRELEASE not found , i have manjaro 64 .
7. 
   MarcoFalke commented at 12:28 pm on April 8, 2020: member

   @modfort Please file a separate issue with steps to reproduce about your build error
8. 
   brakmic commented at 0:29 am on April 10, 2020: contributor

   Hi,

   I’m not sure about the current state of this Issue, so in case my work “clashes” with @modfort ’s , feel free to pilfer any parts that are valuable to you. I won’t be opening a PR unless it’s OK with everyone participating in this thread.

   My solution adds a factor option to BitcoinTestMetaClass in test_framework. First, I tried the same with test_runner but couldn’t forward the factor arg to test cases (error: the options object and/or factor arg were missing…not sure why, I must be missing something important regarding the test framework’s infrastructure).

   Therefore, I went to change BitcoinTestMetaClass.

   The functions with timeoutparameter that I updated are located in authproxy, mininode and test_node. I used @MarcoFalke ’s grep commands (thanks for that!).

   I’ve seen many more functions that expect similar arguments but didn’t want to change them without consultation.

   Cheers,

9. 
   brakmic commented at 8:47 am on April 13, 2020: contributor

   Maybe it’s better to open a proper PR so that others can see that something is happening here? There are so many issues in the backlog and not everyone has enough time to go through all of them to check for changes.

   I will now open a PR, and then we can discuss. If there is anything speaking against it, please let me know.

   Cheers,

10. MarcoFalke closed this on May 3, 2020

    ---

11. ComputerCraftr referenced this in commit f97a9abc4b on Jun 10, 2020
12. DrahtBot locked this on Feb 15, 2022
13. UdjinM6 referenced this in commit 6bb3e54578 on Sep 13, 2022

Contributors
fanquake modfort MarcoFalke brakmic

Labels
Tests good first issue