doc: mention MAKE=gmake workaround when building on a BSD #18340
pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:fixup_18129 changing 3 files +25 −20-
fanquake commented at 3:26 am on March 13, 2020: member
-
fanquake added the label Docs on Mar 13, 2020
-
in doc/build-openbsd.md:56 in db146ecd7f outdated
49@@ -50,7 +50,7 @@ export BDB_PREFIX="$PWD/db4" 50 51 ### Building Bitcoin Core 52 53-**Important**: use `gmake`, not `make`. The non-GNU `make` will exit with a horrible error. 54+**Important**: Use `gmake` (the non-GNU `make` will exit with an error). 55 56 Preparation: 57 ```bash
vasild commented at 8:17 am on March 16, 2020:nit: since you replacedbash
withshell
inbuild-netbsd.md
, if you would be updating the patch, maybes/bash/shell/
also here inbuild-openbsd.md
. But the patch is good to go as is IMO since its purpose is to deal withMAKE=gmake
issue.
fanquake commented at 0:05 am on March 18, 2020:Thanks, I’ve addressed this.vasild approvedvasild commented at 8:18 am on March 16, 2020: memberACK db146ecddongcarl commented at 3:39 pm on March 16, 2020: memberCode Review ACK db146ecd7fabff3457102c9a6ef35d2bd1b7c3b0 Would like it if we took the opportunity to make the syntax highlighting hints more uniform but no worries. (I’m guessing “shell” means POSIX-compliant shell?)doc: mention MAKE=gmake workaround when building on a BSD
Fixes: #14404
fanquake force-pushed on Mar 18, 2020fanquake commented at 0:05 am on March 18, 2020: memberGiven the syntax highlighting was pointed out twice, I’ve pushed to fix that up. I settled on usingbash
because that resulted in more highlighting in the editor I was looking at. On GitHub usingbash
vsshell
doesn’t seem to make a difference.vasild commented at 7:19 am on March 18, 2020: memberACK https://github.com/bitcoin/bitcoin/pull/18340/commits/84a46a9b93671b899faf3900936904199d92daaf
These changes to the FreeBSD installation instructions broke travis Linux badly: heap-use-after-free (pid=27489)!
laanwj commented at 2:50 pm on March 19, 2020: memberACK 84a46a9b93671b899faf3900936904199d92daaflaanwj merged this on Mar 19, 2020laanwj closed this on Mar 19, 2020
sidhujag referenced this in commit decb1c62d0 on Mar 19, 2020fanquake deleted the branch on Mar 20, 2020sidhujag referenced this in commit 70ff1f8cac on Nov 10, 2020DrahtBot locked this on Feb 15, 2022
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-30 03:12 UTC
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-30 03:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me