doc: mention MAKE=gmake workaround when building on a BSD #18340

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:fixup_18129 changing 3 files +25 −20

fanquake commented at 3:26 AM on March 13, 2020: member

Fixes: #14404. Replaces: #18129.
fanquake added the label Docs on Mar 13, 2020
fanquake cross-referenced this on Mar 13, 2020 from issue Doc: Fix BSD docs regarding gmake by abitfan
fanquake commented at 3:27 AM on March 13, 2020: member

cc @dongcarl @laanwj @vasild @murrayn
in doc/build-openbsd.md:56 in db146ecd7f outdated
```
  49 | @@ -50,7 +50,7 @@ export BDB_PREFIX="$PWD/db4"
  50 |  
  51 |  ### Building Bitcoin Core
  52 |  
  53 | -**Important**: use `gmake`, not `make`. The non-GNU `make` will exit with a horrible error.
  54 | +**Important**: Use `gmake` (the non-GNU `make` will exit with an error).
  55 |  
  56 |  Preparation:
  57 |  ```bash
```
vasild commented at 8:17 AM on March 16, 2020:

nit: since you replaced bash with shell in build-netbsd.md, if you would be updating the patch, maybe s/bash/shell/ also here in build-openbsd.md. But the patch is good to go as is IMO since its purpose is to deal with MAKE=gmake issue.

fanquake commented at 12:05 AM on March 18, 2020:

Thanks, I've addressed this.
vasild approved
vasild commented at 8:18 AM on March 16, 2020: contributor

ACK db146ecd
dongcarl commented at 3:39 PM on March 16, 2020: contributor

Code Review ACK db146ecd7fabff3457102c9a6ef35d2bd1b7c3b0 Would like it if we took the opportunity to make the syntax highlighting hints more uniform but no worries. (I'm guessing "shell" means POSIX-compliant shell?)
doc: mention MAKE=gmake workaround when building on a BSD
Fixes: #14404
84a46a9b93
fanquake force-pushed on Mar 18, 2020
fanquake commented at 12:05 AM on March 18, 2020: member

Given the syntax highlighting was pointed out twice, I've pushed to fix that up. I settled on using bash because that resulted in more highlighting in the editor I was looking at. On GitHub using bash vs shell doesn't seem to make a difference.
vasild commented at 7:19 AM on March 18, 2020: contributor

ACK https://github.com/bitcoin/bitcoin/pull/18340/commits/84a46a9b93671b899faf3900936904199d92daaf

These changes to the FreeBSD installation instructions broke travis Linux badly: heap-use-after-free (pid=27489)!
laanwj commented at 2:50 PM on March 19, 2020: member

ACK 84a46a9b93671b899faf3900936904199d92daaf
laanwj merged this on Mar 19, 2020
laanwj closed this on Mar 19, 2020
sidhujag referenced this in commit decb1c62d0 on Mar 19, 2020
fanquake deleted the branch on Mar 20, 2020
MarkLTZ cross-referenced this on Apr 4, 2020 from issue Bitcoin PR tracking by MarkLTZ
sidhujag referenced this in commit 70ff1f8cac on Nov 10, 2020
bitcoin locked this on Feb 15, 2022

Contributors

Labels

Linked (view graph)

#14404 ./configure error on FreeBSD #18129 Doc: Fix BSD docs regarding gmake