Updated text on send confirmation dialog #18351

1. 
   dannmat commented at 4:06 pm on March 14, 2020: none

   I have changed the text on the send confirmation dialog, as it still referenced BIP 125 (which was first proposed back in 2015). I don’t think users need to see which BIP proposed the change 4 years later.

   I also changed the title text to be more user friendly.

2. Updated text on send confirmation dialog 7237f92811
3. 
   MarcoFalke commented at 4:22 pm on March 14, 2020: member

   The issue with changing translated strings is that all translations in all languages get discarded. This has to be weight against the benefit of the new string.
4. DrahtBot added the label GUI on Mar 14, 2020
5. 
   DrahtBot commented at 10:30 pm on March 14, 2020: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #18789 (qt: Add Create Unsigned button to SendConfirmationDialog by achow101)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

6. laanwj added this to the milestone 0.21.0 on Mar 16, 2020
7. 
   laanwj commented at 12:10 pm on March 16, 2020: member

   It’s too late for 0.20.0, the strings and translations freeze are past. Could consider after the branch-off though.
8. DrahtBot added the label Needs rebase on Mar 23, 2020
9. 
   jonasschnelli commented at 11:15 am on April 8, 2020: contributor

   I prefer the new (in this PR) text. Seems more clear and user focused. Comparing screenshots would be nice. utACK 7237f928118f3ab2df4a905304ef9141f150e2d4 (for 0.21).
10. 
    dannmat commented at 12:01 pm on April 9, 2020: none

    I prefer the new (in this PR) text. Seems more clear and user focused. Comparing screenshots would be nice. utACK 7237f92 (for 0.21).

    Here is the modal pre-change:

    Here is the modal post-change:

    The changes aren’t too noticeable on Mac, it’s more for Windows/Linux, which make use of the windowTitle property.

11. 
    luke-jr commented at 11:12 pm on April 22, 2020: member

    “signaling” at least should be lowercase

    I’m not sure the BIP 125 reference is obsolete, though - it’s the specification itself for a policy, not a one-off change.

12. 
    jonasschnelli commented at 9:08 am on May 29, 2020: contributor

    Needs rebase.
13. Merge branch 'master' into Mar-20-send-confirmation-dialog 0b717249d7
14. DrahtBot removed the label Needs rebase on Jun 2, 2020
15. 
    adamjonas commented at 5:11 pm on June 19, 2020: member

    I’m getting post-rebase build errors consistent with the CI. @dannmat mind taking a look?

     0qt/sendcoinsdialog.cpp:337:13: error: use of undeclared identifier 'questionString'; did you mean 'question_string'?
     1            questionString.append(tr("You can increase the fee later (Signaling Replace-By-Fee)."));
     2            ^~~~~~~~~~~~~~
     3            question_string
     4qt/sendcoinsdialog.cpp:223:48: note: 'question_string' declared here
     5bool SendCoinsDialog::PrepareSendText(QString& question_string, QString& informative_text, QString& detailed_text)
     6                                               ^
     7qt/sendcoinsdialog.cpp:339:13: error: use of undeclared identifier 'questionString'; did you mean 'question_string'?
     8            questionString.append(tr("You cannot increase the fee later (Not signalling Replace-By-Fee)"));
     9            ^~~~~~~~~~~~~~
    10            question_string
    11qt/sendcoinsdialog.cpp:223:48: note: 'question_string' declared here
    12bool SendCoinsDialog::PrepareSendText(QString& question_string, QString& informative_text, QString& detailed_text)
    

16. 
    dannmat commented at 4:24 pm on June 20, 2020: none

    Yep I can take a look at this 👍
17. 
    fanquake commented at 6:58 am on July 15, 2020: member

    Hi @dannmat. This is a fairly simple wording change, but as-is, it doesn’t compile, and the commits needs cleaning up. If you do still want to follow up with this change, I’m going to suggest re-opening your PR in the gui repo: https://github.com/bitcoin-core/gui. There are currently a few other tooltip/text related PRs open there as well.
18. fanquake closed this on Jul 15, 2020

    ---

19. 
    dannmat commented at 12:26 pm on July 18, 2020: none

    Hi @fanquake. Sorry I didn’t get chance to clean this commit up. I’ll re-open this in the new gui repo.

    Thanks, Matt

20. DrahtBot locked this on Feb 15, 2022

Contributors
dannmat MarcoFalke DrahtBot laanwj jonasschnelli luke-jr adamjonas fanquake

Labels
GUI

Milestone
0.21.0