These changes block a wallet unload until the GUI completes the process of its model loading.
Fix #18362
gui: Fix segfault for loading and immediately unloading wallet #18387
pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:20200319-fix-modelwallet-segfault changing 4 files +25 −0-
hebasto commented at 9:54 PM on March 19, 2020: member
-
hebasto commented at 9:57 PM on March 19, 2020: member
@ryanofsky Not sure about this PR approach w.r.t. upcoming multiprocessing.
- hebasto renamed this:
qt: Fix segfault for loading and immediately unloading wallet
gui: Fix segfault for loading and immediately unloading wallet
on Mar 19, 2020 -
gui: Fix segfault for loading and immediately unloading wallet 81d4a7b7e3
- hebasto force-pushed on Mar 19, 2020
- DrahtBot added the label GUI on Mar 19, 2020
- DrahtBot added the label Wallet on Mar 19, 2020
-
promag commented at 10:32 PM on March 19, 2020: member
NACK, sorry but I think this is really the wrong approach.
-
DrahtBot commented at 12:14 AM on March 20, 2020: member
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #17966 (qt, refactor: Optimize signal-slot connections logic by hebasto)
- #17954 (wallet: Remove calls to Chain::Lock methods by ryanofsky)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
-
ryanofsky commented at 2:51 AM on March 20, 2020: member
Confirmed 81d4a7b7e3d096ef6f7586eb34dfd2653432c504 works and stops the segfaults. Thanks for the fix! Also agree that the simpler, non-blocking fix 838ea490dd2641e746f870182822dcdf060caa89 from #18338 is probably more robust, and less likely to lead to gui hangs or deadlocks if code is changed in the future.
@ryanofsky Not sure about this PR approach w.r.t. upcoming multiprocessing.
Should be no interaction, at least with #10102 all stc/interfaces calls are normal blocking calls that run in the same order, just slower
-
- hebasto closed this on Mar 23, 2020
- hebasto deleted the branch on Jun 13, 2020
- DrahtBot locked this on Feb 15, 2022
