ci: Run feature_block in valgrind #18392

pull MarcoFalke wants to merge 2 commits into bitcoin:master from MarcoFalke:2003-ciMoreVal changing 4 files +10 −17

MarcoFalke commented at 4:16 PM on March 20, 2020: member

Also revert commit 0a4912e46aecef6f04c6287508020ec60424ed24, because some tests take too long for this to be useful anymore.
MarcoFalke force-pushed on Mar 20, 2020
DrahtBot added the label Tests on Mar 20, 2020
MarcoFalke commented at 5:37 PM on March 20, 2020: member

Open-Close to re-run ci. See #15847 (comment)
MarcoFalke closed this on Mar 20, 2020
MarcoFalke reopened this on Mar 20, 2020
test: Remove ci timeout restriction in test_runner fa01febeaf
MarcoFalke force-pushed on Mar 21, 2020
practicalswift commented at 8:29 AM on March 21, 2020: contributor

Concept ACK: we need to check for the use of uninitialized memory (UUM) in all tests

This one fixes feature_block which is good. What about the remaining two -- feature_abortnode and rpc_bind?
MarcoFalke force-pushed on Mar 21, 2020
MarcoFalke commented at 4:31 PM on March 21, 2020: member

Added a commit to enable feature_abortnode as requested by @practicalswift . Can't enable rpc_bind because of this bug here: #17765 (comment)
ci: Run feature_block and feature_abortnode in valgrind fa92af5af3
MarcoFalke force-pushed on Mar 22, 2020
practicalswift commented at 2:17 PM on March 22, 2020: contributor

@MarcoFalke Why is RUN_FUNCTIONAL_TESTS=true removed? :)

MarcoFalke commented at 2:26 PM on March 22, 2020: member

It is the default value, no need to set it to true twice.

$ git grep RUN_FUNCTIONAL_TESTS
ci/test/00_setup_env.sh:export RUN_FUNCTIONAL_TESTS=${RUN_FUNCTIONAL_TESTS:-true}

Contributors

Labels