build: Fix libevent linking for bench_bitcoin binary #18397

pull hebasto wants to merge 2 commits into bitcoin:master from hebasto:20200321-libevent changing 2 files +3 −3

hebasto commented at 12:30 pm on March 21, 2020: member

This change fixes libevent linking error for the bench_bitcoin binary.

This PR is an alternative to #18377. Fix #18373.

Also fixed a typo in EVENT_CFLAGS variable noted by brakmic.
build: Fix libevent linking for bench_bitcoin binary f709ad0c90
build: Fix typo in EVENT_CFLAGS variable
Co-authored-by: Harris <brakmic@gmail.com>
cd04286825
fanquake added the label Build system on Mar 21, 2020
MarcoFalke added the label Needs gitian build on Mar 21, 2020
MarcoFalke closed this on Mar 21, 2020
MarcoFalke reopened this on Mar 21, 2020
DrahtBot commented at 7:25 pm on March 21, 2020: member
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:
- #18307 (build: Require pkg-config for all of the hosts by hebasto)
- #15112 (build: Optionally enable -Wzero-as-null-pointer-constant by Empact)
- #14920 (Build: enable -Wdocumentation via isystem by Empact)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

DrahtBot commented at 5:15 pm on March 22, 2020: member

Gitian builds

File	commit 5504703a9f8388dff66d33bd077bcc4c82dff6c8(master)	commit 60517f880c98c0343fd8cecde4df3dde2dfbecf1(master and this pull)
bitcoin-0.19.99-aarch64-linux-gnu-debug.tar.gz	`d906d729a9e0aa8a...`	`a40201a2bad19bcc...`
bitcoin-0.19.99-aarch64-linux-gnu.tar.gz	`9d061a629d1f6493...`	`c69b8411decaf75d...`
bitcoin-0.19.99-arm-linux-gnueabihf-debug.tar.gz	`e653316207dc9d5f...`	`666de1b0246493da...`
bitcoin-0.19.99-arm-linux-gnueabihf.tar.gz	`c1252fce8a9e4dcc...`	`76d531b424fd87d0...`
bitcoin-0.19.99-osx-unsigned.dmg	`b27dc85a5839aa01...`	`66d6b4e28c34c5d6...`
bitcoin-0.19.99-osx64.tar.gz	`0b6d6ab4550e9e80...`	`7d21908e90d8baa6...`
bitcoin-0.19.99-riscv64-linux-gnu-debug.tar.gz	`0b581664aa7e71c0...`	`5f318b33294c42c8...`
bitcoin-0.19.99-riscv64-linux-gnu.tar.gz	`9055fdec76ec30e9...`	`92c81af055102343...`
bitcoin-0.19.99-win64-debug.zip	`87b0ccd2625315bf...`	`a40e4fef1008844c...`
bitcoin-0.19.99-win64-setup-unsigned.exe	`7c43dd66ee9381df...`	`ae5333ee3bf39af1...`
bitcoin-0.19.99-win64.zip	`5d07503079a05cea...`	`80e7c2a06d14d6df...`
bitcoin-0.19.99-x86_64-linux-gnu-debug.tar.gz	`b5c4b3d860a8041e...`	`16aeb6ed1847e2fc...`
bitcoin-0.19.99-x86_64-linux-gnu.tar.gz	`b2a95cafa3d16933...`	`a66ff38cefa35ef4...`
bitcoin-0.19.99.tar.gz	`c74b1b1ad84e1065...`	`6bd41ad34fb8ce18...`
bitcoin-core-linux-0.20-res.yml	`48a03fc68c71a926...`	`3626d0481e07fc7a...`
bitcoin-core-osx-0.20-res.yml	`f1439a184460cb40...`	`0b7f81612442edfd...`
bitcoin-core-win-0.20-res.yml	`01a86daf223f2965...`	`aa6670e3c679b4e4...`
linux-build.log	`ca02e3c29b81c8ad...`	`a08e892b5df2869f...`
osx-build.log	`f9d5833739965581...`	`80675ee7c060424f...`
win-build.log	`9ac4e16e1774f0a4...`	`13b32ccedd36c7ba...`
bitcoin-core-linux-0.20-res.yml.diff		`b14e029ed98e9768...`
bitcoin-core-osx-0.20-res.yml.diff		`29677d38518eae06...`
bitcoin-core-win-0.20-res.yml.diff		`5a18c4821ad09a48...`
linux-build.log.diff		`40c24f88ba5d5478...`
osx-build.log.diff		`99776dfc2a16876a...`
win-build.log.diff		`7269a9568882c865...`

DrahtBot removed the label Needs gitian build on Mar 22, 2020
fanquake approved
fanquake commented at 8:09 am on March 26, 2020: member

ACK cd04286825c6512b46bf59ab7b3dfffb0e36d65b
fanquake merged this on Mar 26, 2020
fanquake closed this on Mar 26, 2020
hebasto deleted the branch on Mar 26, 2020
fanquake referenced this in commit e99ca783cd on Mar 26, 2020
sidhujag referenced this in commit af0f536a13 on Mar 28, 2020
sidhujag referenced this in commit da1f651363 on Mar 28, 2020
MarkLTZ referenced this in commit 8823f65197 on Apr 7, 2020
MarkLTZ referenced this in commit 0a1571d657 on Apr 7, 2020
PastaPastaPasta referenced this in commit 700f54ad4f on Nov 1, 2021
PastaPastaPasta referenced this in commit 93b9968eea on Dec 22, 2021
PastaPastaPasta referenced this in commit f80ac36acb on Dec 22, 2021
DrahtBot locked this on Feb 15, 2022

Contributors
hebasto DrahtBot fanquake

Labels
Build system

build: Fix libevent linking for bench_bitcoin binary #18397

Conflicts

Gitian builds