This is the second commit of #17535.
This PR extends a listsinceblock test to check the new transaction 'blockheight' field recently added in #17437. It also cleans up code in the test function without changing or removing existing checks.
test: listsinceblock block height checks #18420
pull jonatack wants to merge 1 commits into bitcoin:master from jonatack:listsinceblock-block-height-checks changing 1 files +9 −11-
jonatack commented at 3:52 PM on March 24, 2020: member
-
test: listsinceblock block height checks 83e1d92413
- laanwj added the label Tests on Mar 24, 2020
-
fjahr commented at 4:24 PM on March 29, 2020: member
tested ACK 83e1d92413e262e6a876336ec433a6fbc335223a
-
promag commented at 11:02 PM on March 29, 2020: member
Code review 83e1d92413e262e6a876336ec433a6fbc335223a.
- ryanofsky approved
-
ryanofsky commented at 7:01 PM on March 30, 2020: member
Code review ACK 83e1d92413e262e6a876336ec433a6fbc335223a. Nice test improvements!
re: description #18420#issue-393078803
This is the second commit of #17535, which adds coverage for #17437.
It's great to link to other issues, but would recommend writing PR description and that doesn't require reading other pages to understand. Would suggest starting off with something like, "This PR extends listsinceblock test to check new transaction 'blockheight' field recently added in #17437. It also cleans up code in the test function without changing or removing existing checks."
-
jonatack commented at 9:22 PM on March 30, 2020: member
Thanks @ryanofsky for the suggestion; added it to the PR description.
- MarcoFalke merged this on Mar 30, 2020
- MarcoFalke closed this on Mar 30, 2020
- jonatack deleted the branch on Mar 30, 2020
- sidhujag referenced this in commit 6ac6d817e7 on Mar 31, 2020
- Fabcien referenced this in commit 78de14facc on Jan 13, 2021
- DrahtBot locked this on Feb 15, 2022
