Both BitcoinApplication and OptionsModel classes are derived from the QObject class, therefore a parent-child relation could be established to manage the lifetime of an OptionsModel object:
https://github.com/bitcoin/bitcoin/blob/5236b2e267a58870239673c7ec85e5df0cb8fc8e/src/qt/optionsmodel.cpp#L29-L30
This PR does not change behavior.
Both BitcoinApplication and OptionsModel classes are derived from the
QObject class, therefore a parent-child relation could be established to
manage the lifetime of an OptionsModel object.
This commit does not change behavior.
Perhaps also BitcoinApplication#window?
Perhaps also
BitcoinApplication#window?
Unfortunately, this is impossible due to QMainWindow expects a parent of the QWidget type. And the BitcoinApplication class is not derived from the QWidget.
I'd suggest to remove the window from the members of BitcoinApplication class.
Yeah. Why not. I just find it confusing to find a new but not a delete on the same layer of code when using raw pointers.
Yeah. Why not. I just find it confusing to find a
newbut not adeleteon the same layer of code when using raw pointers.
That is how Qt Object Trees work.
ACK 8e08d005989c6b5f7f05e0a1e0ba84f544a76d01.
utACK 8e08d005989c6b5f7f05e0a1e0ba84f544a76d01