build: remove double LIBBITCOIN_SERVER from bench-Makefile #18429

pull brakmic wants to merge 1 commits into bitcoin:master from brakmic:bench-makefile changing 1 files +0 −1

brakmic commented at 12:38 PM on March 25, 2020: contributor

This PR removes the redundant LIBBITCOIN_SERVER linking from bench's Makefile. This PR is similar to #17910

Originally, this PR was part of #18377, which later got replaced by a better one #18397 written by hebasto.
build: remove double LIBBITCOIN_SERVER from bench-Makefile 1f97b69ba2
fanquake added the label Build system on Mar 25, 2020
MarcoFalke added the label Needs gitian build on Mar 25, 2020
laanwj commented at 7:17 PM on March 25, 2020: member

Concept ACK
Empact commented at 8:14 PM on March 25, 2020: member

Code Review ACK https://github.com/bitcoin/bitcoin/pull/18429/commits/1f97b69ba27deb645bf5dd229d0cb97d2baf8f49
sipa commented at 8:32 PM on March 25, 2020: member

ACK unless someone sees a reason why this would break in certain untested environments.

DrahtBot commented at 4:08 AM on March 26, 2020: member

Gitian builds

File	commit 3f5107d008e15efa364c53bd3ed4e819cd2c6712<br>(master)	commit 5876e0d14ed792ee3c677f564d03c8f449e768e0<br>(master and this pull)
bitcoin-0.19.99-aarch64-linux-gnu-debug.tar.gz	`c54ba24037a5f515...`	`baa74f743bcc60e9...`
bitcoin-0.19.99-aarch64-linux-gnu.tar.gz	`af9ed3afb2470996...`	`967f274a0bbd0700...`
bitcoin-0.19.99-arm-linux-gnueabihf-debug.tar.gz	`5f75367316182cda...`	`2c0396fa13b331d4...`
bitcoin-0.19.99-arm-linux-gnueabihf.tar.gz	`09130a219271d5e9...`	`0c5a53e09438e89c...`
bitcoin-0.19.99-osx-unsigned.dmg	`d7215c3115ae6238...`	`98a4fce361a3d2cd...`
bitcoin-0.19.99-osx64.tar.gz	`b7bcf04821dfdefe...`	`ae59e77a24c3cd3a...`
bitcoin-0.19.99-riscv64-linux-gnu-debug.tar.gz	`0fff31b63f9780bc...`	`9558bc495130e0c2...`
bitcoin-0.19.99-riscv64-linux-gnu.tar.gz	`9b711a748c74a876...`	`ea5e74529d7f5667...`
bitcoin-0.19.99-win64-debug.zip	`6db3ea24a8fec68b...`	`537a0702eb11e618...`
bitcoin-0.19.99-win64-setup-unsigned.exe	`ba02debc356a9b25...`	`c33ed0d86a7ed0c0...`
bitcoin-0.19.99-win64.zip	`13ce9ce2c30a9911...`	`41f19446c697268b...`
bitcoin-0.19.99-x86_64-linux-gnu-debug.tar.gz	`05edff0962f27dbd...`	`e883d9b99b354d8b...`
bitcoin-0.19.99-x86_64-linux-gnu.tar.gz	`ead201970ef63f4c...`	`98aa771bf5399261...`
bitcoin-0.19.99.tar.gz	`cd3c1ff29350248f...`	`5f1fae0019b0886e...`
bitcoin-core-linux-0.20-res.yml	`888749de8538c24f...`	`795ca6ba8a59d0e7...`
bitcoin-core-osx-0.20-res.yml	`a2f78c976c2a71c2...`	`7fcbe16210a1f028...`
bitcoin-core-win-0.20-res.yml	`d36622eddbb89bd0...`	`c95dab3d2e031138...`
linux-build.log	`5b5f98c9fb04c753...`	`bcb4d0650c54e711...`
osx-build.log	`61646ea5b19a8042...`	`e43c671e45e5dc47...`
win-build.log	`577098ae11ed401b...`	`e237afd64cdbdc2a...`
bitcoin-core-linux-0.20-res.yml.diff		`bc0d8a6ad60374ed...`
bitcoin-core-osx-0.20-res.yml.diff		`9ce5ce668425dff2...`
bitcoin-core-win-0.20-res.yml.diff		`6164fa6f0798d9a7...`
linux-build.log.diff		`9fa9e0347f396ac6...`
osx-build.log.diff		`11e05e8404765fb7...`
win-build.log.diff		`af4f016f01291092...`

DrahtBot removed the label Needs gitian build on Mar 26, 2020
hebasto approved
hebasto commented at 8:24 AM on March 26, 2020: member

ACK 1f97b69ba27deb645bf5dd229d0cb97d2baf8f49
theStack approved
theStack commented at 8:52 AM on March 26, 2020: member

ACK https://github.com/bitcoin/bitcoin/pull/18429/commits/1f97b69ba27deb645bf5dd229d0cb97d2baf8f49
fanquake merged this on Mar 26, 2020
fanquake closed this on Mar 26, 2020
MarkLTZ referenced this in commit b1eb86a36e on Mar 27, 2020
sidhujag referenced this in commit da1f651363 on Mar 28, 2020
MarkLTZ referenced this in commit f4f75a0371 on Apr 6, 2020
PastaPastaPasta referenced this in commit 700f54ad4f on Nov 1, 2021
PastaPastaPasta referenced this in commit 93b9968eea on Dec 22, 2021
PastaPastaPasta referenced this in commit f80ac36acb on Dec 22, 2021
DrahtBot locked this on Feb 15, 2022