ci: Remove misplaced comments from folded block scalar #18441

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:20200326-arm-yml changing 1 files +6 −4

hebasto commented at 5:06 PM on March 26, 2020: member

On master (f3a91ab0edc70e1bcb7e770f0878f03459c399e1) the build log for ARM contains:

$ export FILE_ENV="./ci/test/00_setup_env_arm.sh"
$ export QEMU_USER_CMD=""
$ export Can=
$ export run=
$ export the=
$ export tests=
$ export natively=
$ export without=
$ export qemu=

Setting up build cache
...

and Screenshot from 2020-03-26 18-58-50

With this PR:

$ export FILE_ENV="./ci/test/00_setup_env_arm.sh"
$ export QEMU_USER_CMD=""

Setting up build cache
...

and Screenshot from 2020-03-26 19-01-56

Also Travis build config validation added: Screenshot from 2020-03-26 19-04-19

in .travis.yml:92 in 5400a347f7 outdated
```
  88 | @@ -87,7 +89,7 @@ jobs:
  89 |        arch: arm64
  90 |        env: >-
  91 |          FILE_ENV="./ci/test/00_setup_env_arm.sh"
  92 | -        QEMU_USER_CMD=""  # Can run the tests natively without qemu
  93 | +        QEMU_USER_CMD=""
```
theStack commented at 5:14 PM on March 26, 2020:

Would it work to place the comment in an extra line instead, between FILE_ENV=... and QEMU_USER_CMD=...? The comment itself would still be helpful for anyone trying to understand or edit the Travis file IMHO.

hebasto commented at 5:19 PM on March 26, 2020:

No, it wouldn't: the > character starts the "Folded Block Scalar". The closest line to place a comment is above env: >-.

in .travis.yml:89 in 5400a347f7 outdated

  88 | @@ -87,7 +89,7 @@ jobs:
  89 |        arch: arm64

MarcoFalke commented at 5:49 PM on March 26, 2020:

      arch: arm64  # Can disable QEMU_USER_CMD and run the tests natively without qemu

hebasto commented at 5:59 PM on March 26, 2020:

Done.

MarcoFalke approved
ci: Remove misplaced comments from folded block scalar
Also Travis build config validation added.
e41e46cee0
hebasto force-pushed on Mar 26, 2020
hebasto commented at 5:58 PM on March 26, 2020: member
Updated 5400a347f7570c1694221082c0e73533d93b93ee -> e41e46cee0d9b98869a569b73dafc5452b4272d6 (pr18441.01 -> pr18441.02, diff):
- @MarcoFalke's comment addressed
MarcoFalke merged this on Mar 26, 2020
MarcoFalke closed this on Mar 26, 2020
hebasto deleted the branch on Mar 26, 2020
DrahtBot locked this on Feb 15, 2022

Contributors

hebasto

theStack

MarcoFalke