Compile/link Bitcoin-Qt.app with -pthread on OSX #1847

pull gavinandresen wants to merge 1 commits into bitcoin:master from gavinandresen:osx_pthread changing 1 files +4 −0

gavinandresen commented at 7:46 PM on September 21, 2012: contributor

There was a report of a mysterious crash on OSX 10.7 that may or may not be caused by this. In any case, Bitcoin-Qt is multi-threaded, so compiling with -pthread is the right thing to do.
Compile/link Bitcoin-Qt.app with -pthread d6c4400d57
in bitcoin-qt.pro:None in d6c4400d57
```
 346 | @@ -346,6 +347,9 @@ macx:LIBS += -framework Foundation -framework ApplicationServices -framework App
 347 |  macx:DEFINES += MAC_OSX MSG_NOSIGNAL=0
 348 |  macx:ICON = src/qt/res/icons/bitcoin.icns
 349 |  macx:TARGET = "Bitcoin-Qt"
 350 | +macx:QMAKE_CFLAGS_THREAD += -pthread
```
Diapolo commented at 9:45 PM on September 21, 2012:

Update: Is this one ever used? I asked because we use the C++ compiler only, no?

Diapolo commented at 9:58 AM on September 23, 2012:

Just want a yes or no here, as all other compiler flags in the pro-file are CXX ones and I want to avoid to add something we don't need here!

laanwj commented at 10:16 AM on September 23, 2012:

I'm sure it will not be used. Looking in the generated makefile, CFLAGS is only used for .c -> o compilation.

Diapolo commented at 10:29 AM on September 23, 2012:

And that is, why I vote for removing it :). @gavinandresen Would you remove that line from your patch then?
BitcoinPullTester commented at 11:07 PM on September 21, 2012: none
Automatic sanity-testing: FAILED BUILD/TEST, see http://jenkins.bluematt.me/pull-tester/d6c4400d57c6d6eaba7ef23ba24371069ec037e5 for binaries and test log.

This could happen for one of several reasons:
1. It chanages paths in makefile.linux-mingw or otherwise changes build scripts in a way that made them incompatible with the automated testing scripts
2. It does not build on either Linux i386 or Win32 (via MinGW cross compile)
3. The test suite fails on either Linux i386 or Win32
4. The block test-cases failed (lookup the first bNN identifier which failed in https://github.com/TheBlueMatt/test-scripts/blob/master/FullBlockTestGenerator.java)
laanwj commented at 6:47 AM on September 22, 2012: member

ACK

I don't understand the pull tester output "Error: An error occurred while setting up the RPC port 8332 for listening on IPv4: Address already in use". Seems that a previous test run was still running? @TheBlueMatt
TheBlueMatt commented at 8:40 PM on September 22, 2012: member

@laanwj sorry, should be fixed now
BitcoinPullTester commented at 4:01 AM on September 24, 2012: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/d6c4400d57c6d6eaba7ef23ba24371069ec037e5 for binaries and test log.
laanwj referenced this in commit dc2a68dc43 on Sep 25, 2012
laanwj merged this on Sep 25, 2012
laanwj closed this on Sep 25, 2012
DrahtBot locked this on Sep 8, 2021

Contributors