doc: Update docs for getbalance (default minconf should be 0) #18502

1. 
   uzyn commented at 12:16 pm on April 2, 2020: contributor

   • Default minconf for getbalance is 0 but example in doc was showing as 1.
   • at least 6 blocks confirmed now updated to be at least 6 confirmations to be more consistent with the terminology used elsewhere in the codebase and documentations.
2. fanquake added the label Docs on Apr 2, 2020
3. 
   DrahtBot commented at 12:26 pm on April 2, 2020: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #15729 (rpc: Raise error in getbalance if minconf is not zero by promag)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. 
   theStack commented at 7:42 pm on April 11, 2020: member

   ACK, LGTM. I think it would make sense to squash the two commits into one.
5. 
   uzyn commented at 5:44 am on April 13, 2020: contributor

   ACK, LGTM. I think it would make sense to squash the two commits into one.

   Sure. I felt they are 2 separate ideas, thus they are separate. Got your point though. Should I close this issue and resubmit with the squashed commits?

6. 
   fanquake commented at 6:04 am on April 13, 2020: member

   Should I close this issue and resubmit with the squashed commits?

   There’s no need to open a new PR just to squash commits, you can do that in this PR.

7. doc: default minconf for getbalance should be 0 c0af173da2
8. uzyn force-pushed on Apr 13, 2020
9. theStack approved
10. 
    theStack commented at 11:21 am on April 13, 2020: member

    re-ACK https://github.com/bitcoin/bitcoin/pull/18502/commits/c0af173da20cc4560523205bc268677a808a43df
11. MarcoFalke merged this on Apr 13, 2020
12. MarcoFalke closed this on Apr 13, 2020

    ---

13. deadalnix referenced this in commit 28e2e62864 on Jan 15, 2021
14. vijaydasmp referenced this in commit 6e62b828a7 on Aug 29, 2021
15. vijaydasmp referenced this in commit 7fe857bc51 on Aug 30, 2021
16. PastaPastaPasta referenced this in commit c52da55520 on Aug 31, 2021
17. DrahtBot locked this on Feb 15, 2022

Contributors
uzyn DrahtBot theStack fanquake

Labels
Docs