fuzz: Add CScriptNum::getint coverage #18510

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2004-fuzzScriptNumGetInt changing 2 files +13 −0

MarcoFalke commented at 1:07 AM on April 3, 2020: member
Add coverage for
- https://marcofalke.github.io/btc_cov/fuzz.coverage/src/script/script.h.gcov.html#311
- https://marcofalke.github.io/btc_cov/fuzz.coverage/src/script/script.h.gcov.html#511
fuzz: Add CScriptNum::getint coverage faa64af960
fanquake added the label Tests on Apr 3, 2020
DrahtBot commented at 7:47 PM on April 3, 2020: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #18413 (script: prevent UB when computing abs value for num opcode serialize by pierreN)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

in src/test/fuzz/integer.cpp:140 in faa64af960

 135 |  
 136 | +    const CScriptNum script_num{i64};
 137 | +    (void)script_num.getint();
 138 | +    // Avoid negation failure:
 139 | +    // script/script.h:332:35: runtime error: negation of -9223372036854775808 cannot be represented in type 'int64_t' (aka 'long'); cast to an unsigned type to negate this value to itself
 140 | +    if (script_num != CScriptNum{std::numeric_limits<int64_t>::min()}) {

pierreN commented at 8:34 PM on April 3, 2020:

I just saw the conflict with this PR and mine.

If #18413 is merged, is this line useful ?

We can merge this (#18510) first and I'll update my branch accordingly (or the opposite too if you prefer).

practicalswift commented at 2:14 PM on April 4, 2020: contributor

ACK faa64af960b64b522bb088e836c9d8cd6254c6c8 -- more fuzzing coverage is better than less fuzzing coverage :)
MarcoFalke merged this on Apr 4, 2020
MarcoFalke closed this on Apr 4, 2020
MarcoFalke deleted the branch on Apr 4, 2020
sidhujag referenced this in commit e3c78cc206 on Apr 8, 2020
Fabcien referenced this in commit e184da672e on Jan 20, 2021
DrahtBot locked this on Feb 15, 2022

Contributors

Labels

fuzz: Add CScriptNum::getint coverage #18510

Conflicts