Fixed too many spaces in the BlockChain Log #18525

pull JetJadeja wants to merge 1 commits into bitcoin:0.19 from JetJadeja:patch-1 changing 1 files +1 −1
  1. JetJadeja commented at 7:17 PM on April 4, 2020: none

    On line 956, there were 2 spaces in the block chain log

    <!-- *** Please remove the following help text before submitting: *** Pull requests without a rationale and clear improvement may be closed immediately. -->

    <!-- Please provide clear motivation for your patch and explain how it improves Bitcoin Core user experience or Bitcoin Core developer experience significantly: * Any test improvements or new tests that improve coverage are always welcome. * All other changes should have accompanying unit tests (see `src/test/`) or functional tests (see `test/`). Contributors should note which tests cover modified code. If no tests exist for a region of modified code, new tests should accompany the change. * Bug fixes are most welcome when they come with steps to reproduce or an explanation of the potential issue as well as reasoning for the way the bug was fixed. * Features are welcome, but might be rejected due to design or scope issues. If a feature is based on a lot of dependencies, contributors should first consider building the system outside of Bitcoin Core, if possible. * Refactoring changes are only accepted if they are required for a feature or bug fix or otherwise improve developer experience significantly. For example, most "code style" refactoring changes require a thorough explanation why they are useful, what downsides they have and why they *significantly* improve developer experience or avoid serious programming bugs. Note that code style is often a subjective matter. Unless they are explicitly mentioned to be preferred in the [developer notes](/doc/developer-notes.md), stylistic code changes are usually rejected. -->

    <!-- Bitcoin Core has a thorough review process and even the most trivial change needs to pass a lot of eyes and requires non-zero or even substantial time effort to review. There is a huge lack of active reviewers on the project, so patches often sit for a long time. -->

  2. Fixed too many spaces in the BlockChain Log
    On line 956, there were 2 spaces in the block chain log
    4d4228542c
  3. DrahtBot added the label RPC/REST/ZMQ on Apr 4, 2020
  4. practicalswift commented at 9:18 PM on April 4, 2020: contributor

    I thought double spaces between sentences were part of Satoshi's original vision :)

    With that said: if we are to deviate from Satoshi's original vision with regards to spacing I suggest doing this change exhaustively:

    $ git grep -E 'LogPrintf*\(.*?".*?\.  [a-zA-Z].*?"'
    src/init.cpp:        LogPrintf("Block pruning enabled.  Use RPC call pruneblockchain(height) to manually prune block and undo files.\n");
    src/rpc/blockchain.cpp:        LogPrint(BCLog::RPC, "Attempt to prune blocks close to the tip.  Retaining the minimum number of blocks.\n");
    

    Regardless: welcome as a contributor @JetDeveloping! :)

  5. JetJadeja commented at 11:39 PM on April 4, 2020: none

    Hey @practicalswift :).

    Thank you so much for welcoming me. I, of course, don't want to deviate from Satoshi's original vision!

    Once again thanks for telling me as well as welcoming me!

  6. JetJadeja closed this on Apr 4, 2020

  7. sipa commented at 11:47 PM on April 4, 2020: member

    They were actually both added by @mrbandrews in #7871, so I assume it was intentional.

    I think this is mostly a matter of taste.

  8. DrahtBot locked this on Feb 15, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 15:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me