Update include for Qt5 #1853

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:qt-include changing 1 files +2 −2
  1. fanquake commented at 9:31 AM on September 22, 2012: member

    Update

    #include <QtGui/QWidget>

    to

    #include <QWidget>
  2. in src/qt/macdockiconhandler.mm:None in d432cf7f34 outdated 
       1 | @@ -2,7 +2,7 @@
   2 |  #include "macdockiconhandler.h"
   3 |  
   4 |  #include <QtGui/QMenu>
    laanwj commented at 9:59 AM on September 22, 2012:

    Shouldn't we do the same for QMenu?

    fanquake commented at 10:15 AM on September 22, 2012:

    I don't think so. The reason the QWidget gets changed is because in Qt 5 compared to Qt 4 widgets have been split from the QtGui module into a new QtWidgets module.

    See here http://www.kdab.com/porting-from-qt-4-to-qt-5/ under fixing up includes.

    Diapolo commented at 10:18 AM on September 22, 2012:

    As I understand it @fanquake should be right here.

    laanwj commented at 10:47 AM on September 22, 2012:

    Hmm but in other places in the source code we always simply use #include <QMenu>. So I guess it would be more consistent.

  3. Update Qt include
    Update Qmenu include

This is to be more consistent with the rest of the source

Update Qt Includes
    ea9eaf9dec
  4. fanquake commented at 10:57 AM on September 22, 2012: member

    Fixed the other include and merged into one commit.

  5. BitcoinPullTester commented at 9:32 AM on September 23, 2012: none

    Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/ea9eaf9dec203e40d8a88914ca04ae1a8b705128 for binaries and test log.

  6. laanwj referenced this in commit 49b09ec04f on Sep 23, 2012
  7. laanwj merged this on Sep 23, 2012
  8. laanwj closed this on Sep 23, 2012
  9. fanquake deleted the branch on May 12, 2016
  10. KolbyML referenced this in commit e8d13ef4b0 on Dec 5, 2020
  11. DrahtBot locked this on Sep 8, 2021
Contributors
fanquakelaanwjDiapoloBitcoinPullTester
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-26 06:15 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me