Currently the fiasco is only theoretical because all content of the table are compile-time constants. However, the fiasco materializes should they ever become run-time constants (e.g. #18531).
rpc: Avoid initialization-order-fiasco on static CRPCCommand tables #18532
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2004-rpcNoFiasco changing 6 files +12 −12-
MarcoFalke commented at 4:24 PM on April 5, 2020: member
-
rpc: Avoid initialization-order-fiasco on static CRPCCommand tables fa1a92224d
- DrahtBot added the label Mining on Apr 5, 2020
- DrahtBot added the label RPC/REST/ZMQ on Apr 5, 2020
- DrahtBot added the label Wallet on Apr 5, 2020
- MarcoFalke removed the label Mining on Apr 5, 2020
- MarcoFalke removed the label Wallet on Apr 5, 2020
-
DrahtBot commented at 7:36 PM on April 5, 2020: member
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
No conflicts as of last run.
-
promag commented at 8:44 AM on April 6, 2020: member
ACK fa1a92224dd78de817d15bcda35a8310254e1a54.
Also, it seems odd to have the tables sit in memory of util or test binaries where
RegisterAllCoreRPCCommandsis never called.AFAIK memory is always allocated at load.
-
practicalswift commented at 1:37 PM on April 6, 2020: contributor
ACK fa1a92224dd78de817d15bcda35a8310254e1a54 -- fiasco bad :)
- MarcoFalke merged this on Apr 7, 2020
- MarcoFalke closed this on Apr 7, 2020
- MarcoFalke deleted the branch on Apr 7, 2020
- theStack approved
-
theStack commented at 3:56 PM on April 7, 2020: member
- sidhujag referenced this in commit 121b214536 on Apr 8, 2020
- jasonbcox referenced this in commit 7b4304c22c on Dec 1, 2020
- DrahtBot locked this on Feb 15, 2022
