fuzz: Disable debug log file #18571

1. 
   MarcoFalke commented at 11:52 pm on April 8, 2020: member

   There are several issues with writing to a debug log file when fuzzing:

   • Disk access is slow, but fuzzing should be fast (Note: I could not verify this claim with data)
   • Disks have a limited size and will eventually run out of space, but fuzzing should run continuous

   Fix both issues by disabling the debug log file for fuzz tests

2. fanquake added the label Tests on Apr 8, 2020
3. 
   DrahtBot commented at 5:54 am on April 9, 2020: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #18470 (net: Make stale tip check time type-safe, extend test by MarcoFalke)
   • #18077 (net: Add NAT-PMP port forwarding support by hebasto)
   • #17434 (Move parsing from init.cpp to where values are needed by Xekyo)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. DrahtBot added the label Needs rebase on Apr 10, 2020
5. MarcoFalke force-pushed on Apr 11, 2020
6. DrahtBot removed the label Needs rebase on Apr 11, 2020
7. MarcoFalke force-pushed on Apr 13, 2020
8. 
   practicalswift commented at 5:16 pm on April 13, 2020: contributor

   Concept ACK

   Thanks for doing this: faster fuzzing is better fuzzing.

9. MarcoFalke force-pushed on Apr 15, 2020
10. node: Add args alias for gArgs global fad4fa7e2f
11. MarcoFalke force-pushed on Apr 15, 2020
12. 
    MarcoFalke commented at 7:06 pm on April 15, 2020: member

    Rebased now that #18615 is merged
13. test: Add optional extra_args to testing setup fa0cbd48c4
14. fuzz: Disable debug log file fa69f88486
15. MarcoFalke force-pushed on Apr 15, 2020
16. 
    practicalswift commented at 7:39 pm on April 15, 2020: contributor

    ACK fa69f88486e900aacf3fc768671f947927173226 – patch looks correct
17. 
    MarcoFalke commented at 7:40 pm on April 15, 2020: member

    I couldn’t verify my claim that this speeds up fuzzing, but at least I am no longer running out of disk space, so I think it is still required.
18. MarcoFalke merged this on Apr 15, 2020
19. MarcoFalke closed this on Apr 15, 2020

    ---

20. MarcoFalke deleted the branch on Apr 15, 2020
21. deadalnix referenced this in commit 90aaf20e54 on Jun 29, 2020
22. Fabcien referenced this in commit 9461ad6e62 on Dec 9, 2020
23. DrahtBot locked this on Feb 15, 2022

Contributors
MarcoFalke DrahtBot practicalswift

Labels
Tests