bench: Remove requirement that all benches use same testing setup #18575

1. 
   MarcoFalke commented at 4:53 pm on April 9, 2020: member

   The benches have always set up one global testing setup. This makes it hard to pick no testing setup at all or one with different params.

   Fix this by removing any global state setup from the main bench.cpp and leave the setup to each individual bench.

   One reason to have one global testing setup is to set the datadir location to a tempdir to avoid reading or writing in the default datadir location. But #13687 should prevent this already.

2. fanquake added the label Tests on Apr 9, 2020
3. 
   DrahtBot commented at 8:35 pm on April 16, 2020: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #18731 (refactor: Make CCheckQueue RAII-styled by hebasto)
   • #18710 (Add local thread pool to CCheckQueue by hebasto)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. bench: Remove requirement that all benches use RegTestingSetup fab1170964
5. bench: Replace ::mempool globabl with test_setup.mempool

   This is a refactor, since they are aliases for each other

   fa1fdb02fc
6. MarcoFalke force-pushed on Apr 17, 2020
7. 
   MarcoFalke commented at 2:23 pm on April 17, 2020: member

   Rebased, diff is smaller and easier to review now that #18673 has been merged
8. MarcoFalke merged this on Apr 22, 2020
9. MarcoFalke closed this on Apr 22, 2020

   ---

10. MarcoFalke deleted the branch on Apr 22, 2020
11. sidhujag referenced this in commit be86c360ce on Apr 23, 2020
12. Fabcien referenced this in commit 57776826d3 on Jan 22, 2021
13. DrahtBot locked this on Feb 15, 2022

Contributors
MarcoFalke DrahtBot

Labels
Tests