gitian: Add missing automake package to gitian-win-signer.yml #18598

1. 
   achow101 commented at 6:16 PM on April 11, 2020: member

   automake is needed to build osslsigncode otherwise autogen.sh fails with the docker virtualization method.

2. gitian: Add missing automake package to gitian-win-signer.yml

   automake is needed to build osslsigncode otherwise autogen.sh fails.

   e44aeefaae
3. DrahtBot added the label Build system on Apr 11, 2020
4. DrahtBot added the label Scripts and tools on Apr 11, 2020
5. hebasto approved
6. 
   hebasto commented at 8:51 PM on April 11, 2020: member

   ACK e44aeefaaed8d698d1b9004b66f85384397b1a75, for osslsigncode-1.7.1 we did not run autogen.sh in the past.

   It seems the backport to the 0.20 branch is needed.

7. in contrib/gitian-descriptors/gitian-win-signer.yml:11 in e44aeefaae

      7 | @@ -8,6 +8,7 @@ architectures:
      8 |  packages:
      9 |  - "libssl-dev"
     10 |  - "autoconf"
     11 | +- "automake"
   

   ---

   ---

   

   hebasto commented at 8:54 PM on April 11, 2020:

   nit: automake depends on autoconf, therefore, the latter could be dropped.

   ---

   

   achow101 commented at 7:11 PM on April 16, 2020:

   meh.

8. fanquake removed the label Scripts and tools on Apr 12, 2020
9. fanquake added the label Needs backport (0.20) on Apr 12, 2020
10. fanquake approved
11. 
    fanquake commented at 11:09 AM on April 12, 2020: member

    ACK e44aeefaaed8d698d1b9004b66f85384397b1a75

12. 
    hebasto commented at 5:47 PM on April 12, 2020: member

    @achow101 I've managed to sign windows binaries without these changes :)

    UPDATE: my base manifest already containes automake_1%3a1.15.1-3ubuntu2_all.deb Is it due to using LXC?

13. 
    achow101 commented at 5:52 PM on April 12, 2020: member

    @achow101 I've managed to sign windows binaries without these changes :)

    That's interesting. Which virtualization are you using? Can you post your install.log? I use docker which has a very minimal dependency base. So if you are using something else, maybe a dependency is installed that requires automake.

14. 
    hebasto commented at 5:55 PM on April 12, 2020: member

    Can you post your install.log?

    It is not quite informative:

    mesg: ttyname failed: Inappropriate ioctl for device
    Hit:1 http://10.0.3.1:3142/archive.ubuntu.com/ubuntu bionic InRelease
    Hit:2 http://10.0.3.1:3142/security.ubuntu.com/ubuntu bionic-security InRelease
    Hit:3 http://10.0.3.1:3142/archive.ubuntu.com/ubuntu bionic-updates InRelease
    Reading package lists...
    mesg: ttyname failed: Inappropriate ioctl for device
    Reading package lists...
    Building dependency tree...
    Reading state information...
    faketime is already the newest version (0.9.7-2).
    0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
    mesg: ttyname failed: Inappropriate ioctl for device
    

    Which virtualization are you using?

    LXC 3.0.3

15. 
    hebasto commented at 5:57 PM on April 12, 2020: member

    @achow101

    I use docker which has a very minimal dependency base.

    Maybe it is worth to mention Docker in the OP?

16. MarcoFalke added this to the milestone 0.20.0 on Apr 16, 2020
17. 
    jonatack commented at 7:20 PM on April 16, 2020: member

    ACK e44aeef

    Came across this when signing 0.20.0.rc1 for win with docker.

18. laanwj merged this on Apr 16, 2020
19. laanwj closed this on Apr 16, 2020

    ---

20. sidhujag referenced this in commit 289fe1c86b on Apr 17, 2020
21. fanquake referenced this in commit ade4185e63 on Apr 23, 2020
22. fanquake removed the label Needs backport (0.20) on Apr 23, 2020
23. laanwj referenced this in commit fb5b098598 on May 11, 2020
24. backpacker69 referenced this in commit 3f0191df5e on Mar 28, 2021
25. DrahtBot locked this on Feb 15, 2022

Contributors

achow101hebastofanquakejonatack

Milestone
0.20.0