The gui doesn’t handle exceptions very well #18643

1. 
   MarcoFalke commented at 1:17 am on April 15, 2020: member

   The GUI crashes on exceptions such as NonFatalCheckError. I think it is more user friendly for a GUI to catch the exception and display it to the user, then abort the current action and leave the main window running.

   I tested this by mutating the conditional in a CHECK_NONFATAL.

    0$ ./src/qt/bitcoin-qt 
    1QSocketNotifier: Can only be used with threads started with QThread
    2
    3
    4************************
    5EXCEPTION: 18NonFatalCheckError       
    6wallet/wallet.cpp:2636 (IsCurrentForAntiFeeSniping)
    7Internal bug detected: '!chain.findBlock(block_hash, FoundBlock().time(block_time))'
    8You may report this issue here: https://github.com/bitcoin/bitcoin/issues
    9       
   10bitcoin in Runaway exception       
   11
   12terminate called after throwing an instance of 'NonFatalCheckError'
   13  what():  wallet/wallet.cpp:2636 (IsCurrentForAntiFeeSniping)
   14Internal bug detected: '!chain.findBlock(block_hash, FoundBlock().time(block_time))'
   15You may report this issue here: https://github.com/bitcoin/bitcoin/issues
   16
   17Aborted (core dumped)
   

   

2. MarcoFalke added the label Bug on Apr 15, 2020
3. 
   MarcoFalke commented at 1:18 am on April 15, 2020: member

   The RPC currently handles them nicely, by wrapping any exception into an JSONRPCError and returning from the call gracefully.
4. 
   MarcoFalke commented at 1:19 am on April 15, 2020: member

   And unrelated: “Bitcoin can no longer continue safely” sounds interesting, but should probably be replaced by PACKAGE_NAME
5. fanquake added the label GUI on Apr 15, 2020
6. MarcoFalke referenced this in commit 18f11fb24b on Apr 15, 2020
7. 
   hebasto commented at 12:04 pm on May 6, 2020: member

   @MarcoFalke Mind looking into #18897?
8. 
   instagibbs commented at 6:41 pm on May 9, 2020: member

   Seems related: #18924
9. ComputerCraftr referenced this in commit b8579c56cd on Jun 10, 2020
10. 
    fanquake commented at 8:37 am on September 15, 2020: member

    Moved to https://github.com/bitcoin-core/gui/issues/91.
11. fanquake closed this on Sep 15, 2020

    ---

12. laanwj referenced this in commit 03ecceedf6 on Apr 14, 2021
13. DrahtBot locked this on Feb 15, 2022

Contributors
MarcoFalke hebasto instagibbs fanquake

Labels
Bug GUI