gui: use PACKAGE_NAME in exception message #18646

1. 
   fanquake commented at 7:47 AM on April 15, 2020: member

   Should address this comment.

   

   Can be triggered with a diff like:

   diff --git a/src/qt/modaloverlay.cpp b/src/qt/modaloverlay.cpp
   index 6243a71c7..e5d499012 100644
   --- a/src/qt/modaloverlay.cpp
   +++ b/src/qt/modaloverlay.cpp
   @@ -6,6 +6,7 @@
    #include <qt/forms/ui_modaloverlay.h>
    
    #include <qt/guiutil.h>
   +#include <util/check.h>
    
    #include <chainparams.h>
    
   @@ -179,6 +180,7 @@ void ModalOverlay::showHide(bool hide, bool userRequested)
    
    void ModalOverlay::closeClicked()
    {
   +    CHECK_NONFATAL(false);
        showHide(true);
        userClosed = true;
    }
   

   and clicking close in the modal.

   EXCEPTION: 18NonFatalCheckError       
   qt/modaloverlay.cpp:183 (closeClicked)
   Internal bug detected: 'false'
   You may report this issue here: https://github.com/bitcoin/bitcoin/issues
   

2. gui: use PACKAGE_NAME in exception message 1b04302e43
3. fanquake added the label GUI on Apr 15, 2020
4. fanquake requested review from MarcoFalke on Apr 15, 2020
5. 
   jonasschnelli commented at 7:49 AM on April 15, 2020: contributor

   Thanks. utACK 1b04302e43c91cf2353c545e646e50a672eab300 Bitcoin will soon merge this.

6. 
   emilengler commented at 9:43 AM on April 15, 2020: contributor

   utACK 1b04302

7. hebasto approved
8. 
   hebasto commented at 9:45 AM on April 15, 2020: member

   ACK 1b04302e43c91cf2353c545e646e50a672eab300.

9. MarcoFalke added this to the milestone 0.21.0 on Apr 15, 2020
10. MarcoFalke merged this on Apr 15, 2020
11. MarcoFalke closed this on Apr 15, 2020

    ---

12. fanquake deleted the branch on Apr 16, 2020
13. MarkLTZ referenced this in commit d85210bb67 on Apr 19, 2020
14. ComputerCraftr referenced this in commit b8579c56cd on Jun 10, 2020
15. Fabcien referenced this in commit f472f3394c on Jan 15, 2021
16. DrahtBot locked this on Feb 15, 2022

Review Requested
MarcoFalke

Milestone
0.21.0