tests: Add std::locale::global to list of locale dependent functions #18649

pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:locale-dependent-functions changing 1 files +1 −0
  1. practicalswift commented at 10:12 AM on April 15, 2020: contributor

    Add std::locale::global to list of locale dependent functions in lint-locale-dependence.sh.

    We currently flag setlocale(...) as locale dependent, but prior to this commit we didn't flag std::locale::global(...) as such.

    In addition to setting the global C++ locale std::locale::global(...) also does the equivalent of std::setlocale(LC_ALL, ...);.

    Thus the functionality of std::locale::global(...) is a superset of setlocale(...) :)

  2. tests: Add std::locale::global to list of locale dependent functions in lint-locale-dependence.sh
    We currently flag `setlocale(...)` as locale dependent, but prior to this commit we didn't flag
    `std::locale::global(...)` as such.
    
    In addition to setting the global C++ locale `std::locale::global(...)` also does the equivalent
    of `std::setlocale(LC_ALL, ...);`.
    
    Thus the functionality of `std::locale::global(...)` is a superset of `setlocale(...)` :)
    54b5eb2b14
  3. fanquake added the label Tests on Apr 15, 2020
  4. practicalswift commented at 11:28 AM on April 20, 2020: contributor

    @laanwj Would you mind reviewing? You've shown interest in lint-locale-dependence.sh in the past (#13041) :)

  5. MarcoFalke commented at 11:32 AM on April 20, 2020: member

    ACK 54b5eb2b149a1f2a4a1dbdb9e0648c5a390d8e22, fine with me

  6. practicalswift renamed this:
    tests: Add std::locale::global to list of locale dependent functions in lint-locale-dependence.sh
    test: Add std::locale::global to list of locale dependent functions in lint-locale-dependence.sh
    on Apr 24, 2020
  7. practicalswift commented at 7:50 PM on May 10, 2020: contributor

    Anything left to do here? :)

  8. practicalswift renamed this:
    test: Add std::locale::global to list of locale dependent functions in lint-locale-dependence.sh
    tests: Add std::locale::global to list of locale dependent functions in lint-locale-dependence.sh
    on Jun 2, 2020
  9. fanquake renamed this:
    tests: Add std::locale::global to list of locale dependent functions in lint-locale-dependence.sh
    tests: Add std::locale::global to list of locale dependent functions
    on Jul 3, 2020
  10. fanquake merged this on Jul 3, 2020
  11. fanquake closed this on Jul 3, 2020

  12. sidhujag referenced this in commit d0301a80a9 on Jul 8, 2020
  13. practicalswift deleted the branch on Apr 10, 2021
  14. Fabcien referenced this in commit 68f9f7cf8e on Aug 30, 2021
  15. PastaPastaPasta referenced this in commit ca5cb456dd on Apr 3, 2022
  16. DrahtBot locked this on Aug 16, 2022
Labels

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-16 15:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me