0.20.0rc1: Broken -logthreadnames on gitian builds #18652

1. 
   hebasto commented at 12:45 PM on April 15, 2020: member

   On 0.20.0rc1, or on just a gitian build against master (4702cadca94520a36bfe979c85750563c30f7c85), the debug.log contains empty thread names:

   2020-04-15T12:37:41Z [] Bitcoin Core version v0.20.0rc1 (release build)
   ...
   2020-04-15T12:37:41Z [] Config file arg: logthreadnames="1"
   ...
   

   Tested on Linux Mint 19.3 (x86) and ODROID-HC1 (ARM, bionic).

2. hebasto added the label Bug on Apr 15, 2020
3. MarcoFalke added this to the milestone 0.20.0 on Apr 15, 2020
4. MarcoFalke added the label Build system on Apr 15, 2020
5. 
   fanquake commented at 12:55 PM on April 15, 2020: member

   I've just tested the macOS 0.20.0rc1 bitcoind, and threadnames are working:

   2020-04-15T12:53:46.857310Z [init] Bitcoin Core version v0.20.0rc1 (release build)
   2020-04-15T12:53:46.857350Z [init] Assuming ancestors of block 0000000000000000000f2adce67e49b0b6bdeb9de8b7c3d7e93b21e7fc1e819d have valid signatures.
   2020-04-15T12:53:46.857356Z [init] Setting nMinimumChainWork=00000000000000000000000000000000000000000e1ab5ec9348e9f4b8eb8154
   ...
   2020-04-15T12:53:47.312306Z [shutoff] zmq: Shutdown notifier pubrawtx at tcp://127.0.0.1:28332
   2020-04-15T12:53:47.312327Z [shutoff] zmq: Close socket at address tcp://127.0.0.1:28332
   2020-04-15T12:53:47.313334Z [shutoff] Shutdown: done
   

   Can you provide any more information.

6. 
   hebasto commented at 1:32 PM on April 15, 2020: member

   I observed this bug on Linux systems (have not test other platforms yet).

   The first system:

   $ uname -sm
   Linux x86_64
   

   The second one:

   $ uname -sm
   Linux armv7l
   

   Tested binaries are from https://bitcoincore.org/bin/bitcoin-core-0.20.0/test.rc1/

7. 
   hebasto commented at 2:47 PM on April 15, 2020: member

   The same issue with official downloads 0.19.0.1 and 0.19.1 ((

8. 
   hebasto commented at 9:57 PM on April 15, 2020: member

   ~The bug is caused by -fvisibility=hidden compiler option after configure --enable-reduce-exports.~

   ~Not sure which solution would be correct...~

9. 
   hebasto commented at 12:54 AM on April 16, 2020: member

   The observed behavior was introduced in #16059.

   According to that pr, there are some ways to make -logthreadnames work on gitian builds:

   • force --enable-threadlocal or
   • drop --enable-glibc-back-compat

   What could you suggest, @dongcarl ?

10. 
    fanquake commented at 1:04 AM on April 16, 2020: member

    So to clarify, nothing is actually broken, we explicitly don't use thread_local when --enable-glibc-back-compat is passed, which is the case for gitian builds. Hence why they are work for macOS, but not for linux.

    edit: although obviously we should do something about having a runtime option available that will never actually do anything.

11. 
    hebasto commented at 11:55 AM on April 16, 2020: member

    Hence why they are work for macOS, but not for linux.

    Because macOS gitian build does not use --enable-glibc-back-compat.

12. 
    fanquake commented at 12:01 PM on April 16, 2020: member

    Because macOS gitian build does not use --enable-glibc-back-compat.

    Thanks. That wasn't a question, just a typo. s/are//

13. 
    hebasto commented at 12:34 PM on April 16, 2020: member

    @fanquake

    although obviously we should do something about having a runtime option available that will never actually do anything.

    See: #18665.

14. 
    laanwj commented at 1:17 PM on April 16, 2020: member

    So to clarify, nothing is actually broken, we explicitly don't use thread_local when --enable-glibc-back-compat is passed,

    I don't know when thread-local support was added. Is this still necessary after the minimum glibc bump to 2.17?

15. sipa deleted a comment on Apr 17, 2020
16. laanwj referenced this in commit acb4fa0741 on Apr 22, 2020
17. sidhujag referenced this in commit 36106e9ef0 on Apr 23, 2020
18. 
    hebasto commented at 7:02 AM on May 5, 2020: member

    I think this issue is fixed by #18665.

19. hebasto closed this on May 5, 2020

    ---

20. DrahtBot locked this on Feb 15, 2022

Milestone
0.20.0