gui: Add bumpFeePSBT action instead of changing normal bumpfee behavior #18655

1. 
   achow101 commented at 6:57 pm on April 15, 2020: member

   Similar to #18654, instead of a single fee bumping action that changes its behavior based on IsWalletFlagSet(WALLET_FLAG_DISABLE_PRIVATE_KEYS), separate it to have one that always tries to sign and send, and another that copies a psbt to the clipboard. So a new menu action is added and the original action will be disabled if private keys are disabled.

   Split from #18627

2. Add bumpFeePSBT action instead of changing normal bumpfee behavior

   Instead of changing GUI bumpfee behavior based on private keys,
   make a separate menu action to do that.

   fa215adc7a
3. DrahtBot added the label GUI on Apr 15, 2020
4. 
   DrahtBot commented at 11:55 pm on April 15, 2020: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #17956 (gui: Disable unavailable context menu items in transactions tab by kristapsk)
   • #16549 ([WIP] UI external signer support (e.g. hardware wallet) by Sjors)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

5. 
   Sjors commented at 4:07 pm on April 23, 2020: member

   I’m not a fan of cluttering the UI with disabled options. You could hide them instead. But then it’s not very clear to me what the point is of this change.

6. 
   luke-jr commented at 6:08 pm on April 24, 2020: member

   This would likely confuse users as-is.

   Can we simplify the workflow so it always makes a PSBT, but in a way that users can easily sign+broadcast?

   Perhaps the PSBT dialog can become like the current bump-fee dialog unless an expert-mode option is enabled?

7. 
   instagibbs commented at 7:48 pm on April 24, 2020: member

   @Sjors I think this change(along with others) is to de-couple the concept of “disabled private keys” and being able to easily make PSBT stuff in GUI. f.e., in a descriptor wallet you may have 1 of the 3 privkeys in the wallet, so you may want to be able to have both buttons/options displayed to avoid having to figure out solveability.
8. 
   Sjors commented at 12:02 pm on April 26, 2020: member

   I’d rather achieve that by adding a bumpfee dialog, and having a “make PSBT” checkbox. Such a dialog is useful anyway, in order to specify an amount.
9. 
   achow101 commented at 5:48 pm on April 26, 2020: member

   Since this action does eventually bring up a dialog, I can change this to add a button to that dialog.
10. 
    achow101 commented at 9:04 pm on April 27, 2020: member

    Can we simplify the workflow so it always makes a PSBT, but in a way that users can easily sign+broadcast?

    I’ve simplified this workflow by changing SendConfirmationDialog instead. This has been unified with #18656 in #18789.

11. achow101 closed this on Apr 27, 2020

    ---

12. DrahtBot locked this on Feb 15, 2022

Contributors
achow101 DrahtBot Sjors luke-jr instagibbs

Labels
GUI