gui: Add a Make unsigned button next to Send #18656

1. 
   achow101 commented at 6:59 pm on April 15, 2020: member

   Instead of having the Send button mutate into a Create Unsigned button when IsWalletFlagSet(WALLET_FLAG_DISABLE_PRIVATE_KEYS), have a second button that always creates a psbt. The original Send button will then not change its behavior and just disable itself when private keys are disabled.

   #17509 does a refactor that makes this easier, so this PR is dependent on that.

   Split from #18627

2. DrahtBot added the label GUI on Apr 15, 2020
3. DrahtBot added the label RPC/REST/ZMQ on Apr 15, 2020
4. DrahtBot added the label Utils/log/libs on Apr 15, 2020
5. 
   DrahtBot commented at 11:53 pm on April 15, 2020: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #18699 (wallet: Avoid translating RPC errors by MarcoFalke)
   • #16549 ([WIP] UI external signer support (e.g. hardware wallet) by Sjors)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

6. in src/qt/forms/sendcoinsdialog.ui:10 in 2474e98279 outdated

    6@@ -7,7 +7,7 @@
    7     <x>0</x>
    8     <y>0</y>
    9     <width>850</width>
   10-    <height>526</height>
   11+    <height>572</height>
   

   ---

   ---

   

   jonasschnelli commented at 7:19 am on April 16, 2020:

   I would clean out the unnecessary changes in the .ui file (usually done by Qt Creator).

   ---

   

   achow101 commented at 4:37 pm on April 16, 2020:

   Done
7. achow101 force-pushed on Apr 16, 2020
8. 
   promag commented at 0:04 am on April 17, 2020: member

   Concept ACK.
9. DrahtBot added the label Needs rebase on Apr 23, 2020
10. Add Make Unsigned Tx button instead of changing Send's behavior

    Instead of changing Send to make an unsigned tx for wallets with
    private keys disabled, have a separate button for that functionality
    and disable Send for such wallets.

    0acaefa270
11. achow101 force-pushed on Apr 23, 2020
12. DrahtBot removed the label Needs rebase on Apr 23, 2020
13. 
    luke-jr commented at 6:09 pm on April 24, 2020: member

    This would likely confuse users as-is.

    Can we simplify the workflow so it always makes a PSBT, but in a way that users can easily sign+broadcast?

    Perhaps the PSBT dialog can become like the current send confirmation dialog unless an expert-mode option is enabled?

14. 
    instagibbs commented at 7:44 pm on April 24, 2020: member

    I think sticking this behind an expert mode switch is probably the right thing to do at a minimum.
15. 
    achow101 commented at 9:04 pm on April 27, 2020: member

    Can we simplify the workflow so it always makes a PSBT, but in a way that users can easily sign+broadcast?

    I’ve simplified this workflow by changing SendConfirmationDialog instead. This has been unified with #18655 in #18789.

16. achow101 closed this on Apr 27, 2020

    ---

17. DrahtBot locked this on Feb 15, 2022

Contributors
achow101 DrahtBot jonasschnelli promag luke-jr instagibbs

Labels
GUI RPC/REST/ZMQ Utils/log/libs