ci: Limit cache size regardless of NO_DEPENDS #18667

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:200416-ci-cache changing 1 files +2 −5

hebasto commented at 2:10 PM on April 16, 2020: member

Close #18666.
MarcoFalke commented at 2:16 PM on April 16, 2020: member

ACK 0c6318788beaf1a31aeba5a21f3f8bb5c07cea6c . Depends has ccache disabled anyway and is cached regardless of whether ccache is there or not, see #17248
in ci/test/06_script_a.sh:11 in 4f29a488f1 outdated
```
   7 | @@ -8,9 +8,7 @@ export LC_ALL=C.UTF-8
   8 |  
   9 |  BITCOIN_CONFIG_ALL="--disable-dependency-tracking --prefix=$DEPENDS_DIR/$HOST --bindir=$BASE_OUTDIR/bin --libdir=$BASE_OUTDIR/lib"
  10 |  DOCKER_EXEC "command -v ccache > /dev/null && ccache --zero-stats"
  11 | -if [ -z "$NO_DEPENDS" ]; then
  12 | -  DOCKER_EXEC ccache --max-size=$CCACHE_SIZE
  13 | -fi
  14 | +DOCKER_EXEC "command -v ccache > /dev/null && ccache --max-size=$CCACHE_SIZE"
```
MarcoFalke commented at 2:18 PM on April 16, 2020:

DOCKER_EXEC "ccache --max-size=$CCACHE_SIZE"

Ccache is a requirement for ci builds, why would this not be there?
hebasto commented at 2:24 PM on April 16, 2020:

Ccache is a requirement for ci builds...

Yes, it is now. But it seems not guaranteed for custom defined DOCKER_PACKAGES macro: https://github.com/bitcoin/bitcoin/blob/661e8df1b63b213d2d5b0d7cba0733869b508af9/ci/test/00_setup_env.sh#L56

hebasto commented at 2:30 PM on April 16, 2020:

Maybe it is worth to disable ability to provide custom DOCKER_PACKAGES value as we have the PACKAGES macro on that purpose, no?

MarcoFalke commented at 2:50 PM on April 16, 2020:

I still like the ability to provide a custom DOCKER_PACKAGES. ccache is required for the ci in the same way that a compiler or python is required. Without it, it doesn't run.

hebasto commented at 2:59 PM on April 16, 2020:

Updated.
hebasto commented at 2:50 PM on April 16, 2020: member
Updated 4f29a488f19a5eb7ba21f4a9cce5a5fe9a4d8d3d -> 087e7a3b1dd97094792a286ee34c69b9c2f37fc2 (pr18667.01 -> pr18667.02, diff):
- addressed @MarcoFalke's comment:
Ccache is a requirement for ci builds, why would this not be there?
ci: Limit cache size regardless of NO_DEPENDS 0c6318788b
hebasto force-pushed on Apr 16, 2020
hebasto commented at 2:59 PM on April 16, 2020: member
Updated 087e7a3b1dd97094792a286ee34c69b9c2f37fc2 -> 0c6318788beaf1a31aeba5a21f3f8bb5c07cea6c (pr18667.02 -> pr18667.03, diff):
- addressed @MarcoFalke's comment:
I still like the ability to provide a custom DOCKER_PACKAGES. ccache is required for the ci in the same way that a compiler or python is required. Without it, it doesn't run.
MarcoFalke merged this on Apr 16, 2020
MarcoFalke closed this on Apr 16, 2020
hebasto deleted the branch on Apr 16, 2020
sidhujag referenced this in commit 966c2e74c0 on Apr 17, 2020
DrahtBot locked this on Feb 15, 2022

Contributors

hebasto

MarcoFalke

Linked (view graph)

#18666 Investiage why Bitcoin Core is using terabytes of travis cache space