doc: edit for clarity #18714

RandyMcMillan commented at 6:10 AM on April 21, 2020: contributor

No description provided.

doc: edit for clarity f454f16d23

fanquake added the label Docs on Apr 21, 2020

jonasschnelli commented at 7:56 AM on April 21, 2020: contributor

meh ACK f454f16d23d9a4799450faa46ce63803f26d86c1

in depends/README.md:115 in f454f16d23

 114 | +
 115 | +    make download-win # fetch all sources needed for win builds
 116 | +
 117 | +For Linux:
 118 | +
 119 | +    make download-linux # to fetch all sources needed for linux builds

hebasto commented at 9:40 AM on April 21, 2020:

It makes it more confusing, IMO. What does "For macOS" mean: a host system or a target one?

Let's leave it as is :)

jonatack commented at 4:48 PM on April 21, 2020:

I agree with @hebasto that this is less clear than the way it is currently.

MarcoFalke added the label Needs gitian build on Apr 21, 2020

MarcoFalke added the label Needs Guix build on Apr 21, 2020

hebasto commented at 12:23 PM on April 21, 2020: member

@MarcoFalke Why is this labeled "Needs gitian build" ?

MarcoFalke commented at 12:32 PM on April 21, 2020: member

I am testing something and this pull has been selected as the victim

DrahtBot commented at 8:54 PM on April 21, 2020: member

Guix builds

File	commit b6a5dc90bfd4640cf9f914e59bf8e21cd265b51e<br>(master)	commit db44d76108317d96ce100aca3c615e901ef2ec5b<br>(master and this pull)
bitcoin-0.20.99-aarch64-linux-gnu-debug.tar.gz	`8911539c3a98399d...`	`87d2fdb842e49fd7...`
bitcoin-0.20.99-aarch64-linux-gnu.tar.gz	`effc7cd3b40e9851...`	`ce5fbcdee25f7887...`
bitcoin-0.20.99-arm-linux-gnueabihf-debug.tar.gz	`d0af37c71d96019f...`	`08ccd0e47fe8135d...`
bitcoin-0.20.99-arm-linux-gnueabihf.tar.gz	`03d2bb2fda8ace65...`	`110827ce2ce7544c...`
bitcoin-0.20.99-riscv64-linux-gnu-debug.tar.gz	`826aa7578d16575d...`	`d98396e661f82ca5...`
bitcoin-0.20.99-riscv64-linux-gnu.tar.gz	`c5b069fbacbc4ef4...`	`04c738a58ccb649c...`
bitcoin-0.20.99-win-unsigned.tar.gz	`5927d017b6aedf27...`	`f98d5dd6988daa94...`
bitcoin-0.20.99-win64-debug.zip	`3574db7005affa4d...`	`9cc4ac51926f01ba...`
bitcoin-0.20.99-win64-setup-unsigned.exe	`cb2a62561554ae9e...`	`cb2a62561554ae9e...`
bitcoin-0.20.99-win64.zip	`cb47db515ddb5e78...`	`50adcc3b87285df2...`
bitcoin-0.20.99-x86_64-linux-gnu-debug.tar.gz	`080496c827f01827...`	`9869a3d1d0a7fac6...`
bitcoin-0.20.99-x86_64-linux-gnu.tar.gz	`299db6ddd3baf2ab...`	`16a1ff18e91adaf9...`
bitcoin-0.20.99.tar.gz	`a2feedf371c7c369...`	`01d1a20d7049efe5...`
guix_build.log	`b371b20a9a27231d...`	`c121a04ba6662afe...`
guix_build.log.diff		`e33a4027c4a9eee0...`

DrahtBot removed the label Needs Guix build on Apr 21, 2020

DrahtBot commented at 12:39 AM on April 22, 2020: member

Gitian builds

File	commit b6a5dc90bfd4640cf9f914e59bf8e21cd265b51e<br>(master)	commit db44d76108317d96ce100aca3c615e901ef2ec5b<br>(master and this pull)
bitcoin-0.20.99-aarch64-linux-gnu-debug.tar.gz	`f7ee55fae0a748a3...`	`785a9539004b29a2...`
bitcoin-0.20.99-aarch64-linux-gnu.tar.gz	`0440e9a09b0e9eaa...`	`aadb651a25cfafe4...`
bitcoin-0.20.99-arm-linux-gnueabihf-debug.tar.gz	`efd6048dfaad25ea...`	`e43963b7618929e2...`
bitcoin-0.20.99-arm-linux-gnueabihf.tar.gz	`18df68c3af97c2ce...`	`5d11bfc05fb68113...`
bitcoin-0.20.99-osx-unsigned.dmg	`b6a97302da88794f...`	`e61e39e0247d162a...`
bitcoin-0.20.99-osx64.tar.gz	`1bed161c55235767...`	`4672e85c76233ef0...`
bitcoin-0.20.99-riscv64-linux-gnu-debug.tar.gz	`017677840490f369...`	`58e68d4ef2d48d35...`
bitcoin-0.20.99-riscv64-linux-gnu.tar.gz	`288e6ba5fb189c63...`	`da26e7496625e3ae...`
bitcoin-0.20.99-win64-debug.zip	`e8e7e8adb4b5d019...`	`89a34cf44c29d4b0...`
bitcoin-0.20.99-win64-setup-unsigned.exe	`ef080ff06857e1ac...`	`c979032f73bf418f...`
bitcoin-0.20.99-win64.zip	`49d4d5e24dba37ec...`	`4ef4b2b776961934...`
bitcoin-0.20.99-x86_64-linux-gnu-debug.tar.gz	`30dde3e0205a6264...`	`aa8980a2b0c44f66...`
bitcoin-0.20.99-x86_64-linux-gnu.tar.gz	`8ef0d951e28a6f57...`	`ef296f0f2baf6f93...`
bitcoin-0.20.99.tar.gz	`733d9d105c73702f...`	`cb23636304f3bd7c...`
bitcoin-core-linux-0.21-res.yml	`d9130e1cb235b4ab...`	`fe58c524c7a9895e...`
bitcoin-core-osx-0.21-res.yml	`e98ce347449a904b...`	`f64b0b98a8ceae8b...`
bitcoin-core-win-0.21-res.yml	`57eb43a27c3ca720...`	`c5a6761d1817bc16...`
linux-build.log	`85f5a75cdd068b39...`	`ce1233313ec8ade3...`
osx-build.log	`a5e5f84a07071c28...`	`1fd84291ad647699...`
win-build.log	`4d45e559b7957e63...`	`09a8b5ac8da809b4...`
bitcoin-core-linux-0.21-res.yml.diff		`d028bc9c275c49f6...`
bitcoin-core-osx-0.21-res.yml.diff		`43b47891f83ea0ab...`
bitcoin-core-win-0.21-res.yml.diff		`7031792f4e533960...`
linux-build.log.diff		`874a0ebaf99529a4...`
osx-build.log.diff		`8d808130595de16e...`
win-build.log.diff		`08b678108fa4f6eb...`

DrahtBot removed the label Needs gitian build on Apr 22, 2020

MarcoFalke added the label Needs gitian build on Apr 22, 2020

MarcoFalke added the label Needs Guix build on Apr 22, 2020

DrahtBot commented at 1:55 AM on April 22, 2020: member

Guix builds

File	commit b6a5dc90bfd4640cf9f914e59bf8e21cd265b51e<br>(master)	commit db44d76108317d96ce100aca3c615e901ef2ec5b<br>(master and this pull)
bitcoin-0.20.99-aarch64-linux-gnu-debug.tar.gz	`8911539c3a98399d...`	`87d2fdb842e49fd7...`
bitcoin-0.20.99-aarch64-linux-gnu.tar.gz	`effc7cd3b40e9851...`	`ce5fbcdee25f7887...`
bitcoin-0.20.99-arm-linux-gnueabihf-debug.tar.gz	`d0af37c71d96019f...`	`08ccd0e47fe8135d...`
bitcoin-0.20.99-arm-linux-gnueabihf.tar.gz	`03d2bb2fda8ace65...`	`110827ce2ce7544c...`
bitcoin-0.20.99-riscv64-linux-gnu-debug.tar.gz	`826aa7578d16575d...`	`d98396e661f82ca5...`
bitcoin-0.20.99-riscv64-linux-gnu.tar.gz	`c5b069fbacbc4ef4...`	`04c738a58ccb649c...`
bitcoin-0.20.99-win-unsigned.tar.gz	`5927d017b6aedf27...`	`f98d5dd6988daa94...`
bitcoin-0.20.99-win64-debug.zip	`3574db7005affa4d...`	`9cc4ac51926f01ba...`
bitcoin-0.20.99-win64-setup-unsigned.exe	`cb2a62561554ae9e...`	`cb2a62561554ae9e...`
bitcoin-0.20.99-win64.zip	`cb47db515ddb5e78...`	`50adcc3b87285df2...`
bitcoin-0.20.99-x86_64-linux-gnu-debug.tar.gz	`080496c827f01827...`	`9869a3d1d0a7fac6...`
bitcoin-0.20.99-x86_64-linux-gnu.tar.gz	`299db6ddd3baf2ab...`	`16a1ff18e91adaf9...`
bitcoin-0.20.99.tar.gz	`a2feedf371c7c369...`	`01d1a20d7049efe5...`
guix_build.log	`ff5b229da2805e05...`	`ba8153bb9c60fa76...`
guix_build.log.diff		`e7261f8f14449d42...`

DrahtBot removed the label Needs Guix build on Apr 22, 2020

DrahtBot commented at 3:30 AM on April 22, 2020: member

Gitian builds

File	commit b6a5dc90bfd4640cf9f914e59bf8e21cd265b51e<br>(master)	commit db44d76108317d96ce100aca3c615e901ef2ec5b<br>(master and this pull)
bitcoin-0.20.99-aarch64-linux-gnu-debug.tar.gz	`f7ee55fae0a748a3...`	`785a9539004b29a2...`
bitcoin-0.20.99-aarch64-linux-gnu.tar.gz	`0440e9a09b0e9eaa...`	`aadb651a25cfafe4...`
bitcoin-0.20.99-arm-linux-gnueabihf-debug.tar.gz	`efd6048dfaad25ea...`	`e43963b7618929e2...`
bitcoin-0.20.99-arm-linux-gnueabihf.tar.gz	`18df68c3af97c2ce...`	`5d11bfc05fb68113...`
bitcoin-0.20.99-osx-unsigned.dmg	`b6a97302da88794f...`	`e61e39e0247d162a...`
bitcoin-0.20.99-osx64.tar.gz	`1bed161c55235767...`	`4672e85c76233ef0...`
bitcoin-0.20.99-riscv64-linux-gnu-debug.tar.gz	`017677840490f369...`	`58e68d4ef2d48d35...`
bitcoin-0.20.99-riscv64-linux-gnu.tar.gz	`288e6ba5fb189c63...`	`da26e7496625e3ae...`
bitcoin-0.20.99-win64-debug.zip	`e8e7e8adb4b5d019...`	`89a34cf44c29d4b0...`
bitcoin-0.20.99-win64-setup-unsigned.exe	`ef080ff06857e1ac...`	`c979032f73bf418f...`
bitcoin-0.20.99-win64.zip	`49d4d5e24dba37ec...`	`4ef4b2b776961934...`
bitcoin-0.20.99-x86_64-linux-gnu-debug.tar.gz	`30dde3e0205a6264...`	`aa8980a2b0c44f66...`
bitcoin-0.20.99-x86_64-linux-gnu.tar.gz	`8ef0d951e28a6f57...`	`ef296f0f2baf6f93...`
bitcoin-0.20.99.tar.gz	`733d9d105c73702f...`	`cb23636304f3bd7c...`
bitcoin-core-linux-0.21-res.yml	`d9130e1cb235b4ab...`	`fe58c524c7a9895e...`
bitcoin-core-osx-0.21-res.yml	`e98ce347449a904b...`	`f64b0b98a8ceae8b...`
bitcoin-core-win-0.21-res.yml	`57eb43a27c3ca720...`	`c5a6761d1817bc16...`
linux-build.log	`b7ed2d66a3ac6613...`	`4b1cbc084bd8589a...`
osx-build.log	`91de30bd96a41585...`	`5d87e3599534b404...`
win-build.log	`570b70ee82802b38...`	`fcf715da65c2275a...`
bitcoin-core-linux-0.21-res.yml.diff		`d028bc9c275c49f6...`
bitcoin-core-osx-0.21-res.yml.diff		`43b47891f83ea0ab...`
bitcoin-core-win-0.21-res.yml.diff		`7031792f4e533960...`
linux-build.log.diff		`3c0c6e5ed6817e2a...`
osx-build.log.diff		`2ebd3e4d182fbf62...`
win-build.log.diff		`557cf8200c843863...`

DrahtBot removed the label Needs gitian build on Apr 22, 2020

fanquake commented at 6:31 AM on April 22, 2020: member

Thanks, however I agree with the other comments. I'm not sure that the additional titles & whitespace are clarifying anything; the existing doc seems pretty clear as is.

fanquake closed this on Apr 22, 2020

RandyMcMillan commented at 10:56 PM on April 22, 2020: contributor

Besides clarity...it is easier to copy and paste the command. The change also conforms with the existing indented code block markdown as opposed to the fenced code block markdown. Indented code blocks are more portable across markdown interpreters and should probably be a standard practice for markdown in the documentation. Fenced code blocks with syntax highlighting should be avoided all together.

MarcoFalke commented at 11:02 AM on April 23, 2020: member

I think it would have helped to state the motivation in the commit message or pull request description. Sometimes it is hard to see the reasoning from just a diff.

DrahtBot locked this on Feb 15, 2022