See the corresponding pull #18612
test: Remove unused, undocumented and misleading CScript.__add__ #18732
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2004-testNoScriptAdd changing 3 files +5 −11-
MarcoFalke commented at 1:01 PM on April 22, 2020: member
-
test: Remove unused, undocumented and misleading CScript.__add__ faff9e4bb4
- fanquake added the label Tests on Apr 22, 2020
-
laanwj commented at 1:11 PM on April 22, 2020: member
ACK faff9e4bb431919a4bc7e4dc4a9ca188e2d18113 provided it passes Travis
-
hebasto commented at 1:44 PM on April 22, 2020: member
feature_fee_estimation.pyfailed on CentOS build. -
practicalswift commented at 2:24 PM on April 22, 2020: contributor
Concept ACK: removed is better than unused (unused can be buggy, removed cannot)
-
MarcoFalke commented at 2:27 PM on April 22, 2020: member
feature_fee_estimation.py failed on CentOS build.
Thanks, reported as bug #18737
-
DrahtBot commented at 7:48 PM on April 22, 2020: member
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #18613 (WIP: Make CScript addition concatenative by JeremyRubin)
- #18585 (test: use zero-argument super() shortcut (Python 3.0+) by theStack)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- MarcoFalke merged this on Apr 22, 2020
- MarcoFalke closed this on Apr 22, 2020
- MarcoFalke deleted the branch on Apr 22, 2020
- Fabcien referenced this in commit b92af5e5d4 on Jan 19, 2021
- DrahtBot locked this on Feb 15, 2022
Contributors
Labels