[0.20] rc2 Backports #18748

1. 
   fanquake commented at 6:36 AM on April 23, 2020: member

   Currently backports the following to the 0.20 branch:

   • #18598 - gitian: Add missing automake package to gitian-win-signer.yml
   • #18702 - build: fix ASLR for bitcoin-cli on Windows
   • #18676 - build: Check libevent minimum version in configure script
   • #18665 - Do not expose and consider -logthreadnames when it does not work
   • #18553 - Avoid non-trivial global constants in SHA-NI code
   • #18589 - Fix naming of macOS SDK and clarify version
2. gitian: Add missing automake package to gitian-win-signer.yml

   automake is needed to build osslsigncode otherwise autogen.sh fails.
   
   Github-Pull: #18598
   Rebased-From: e44aeefaaed8d698d1b9004b66f85384397b1a75

   ade4185e63
3. Avoid non-trivial global constants in SHA-NI code

   Github-Pull: #18553
   Rebased-From: 850847309458f43fc7ce6c13fa08c86e1cae042a

   842b13a5f4
4. build: Set libevent minimum version to 2.0.21

   Github-Pull: #18676
   Rebased-From: b68e71796792a9da9daa0a4e759d284d15595230

   1d1e3585fe
5. build: fix ASLR for bitcoin-cli on Windows

   ASLR is not currently working for the bitcoin-cli.exe binary. This is
   due to it not having a .reloc section, which is stripped by default by
   the mingw-w64 ld we use for gitian builds. A good summary of issues with
   ld and mingw-w64 is available in this thread:
   https://sourceware.org/bugzilla/show_bug.cgi?id=19011.
   
   All other Windows binaries that we distribute (bitcoind, bitcoin-qt,
   bitcoin-wallet, bitcoin-tx and test_bitcoin) do not suffer this issue,
   and currently having working ASLR. This is due to them exporting
   (inadvertent or not) libsecp256k1 symbols, and, as a result, the .reloc
   section is not stripped by ld.
   
   This change is a temporary workaround, also the same one described here:
   https://www.kb.cert.org/vuls/id/307144/, that causes main() to be
   exported. Exporting a symbol will mean that the .reloc section is not
   stripped, and ASLR will function correctly.
   
   Github-Pull: #18702
   Rebased-From: 315a4d36f716341a38bc4e4de8630b3246d27dbc

   6986b26346
6. Do not expose and consider -logthreadnames when it does not work

   Github-Pull: #18665
   Rebased-From: b91e4ae0d8ab2ae6b77585c97c52d825f56ed539

   54d2063d1a
7. fanquake added the label Backport on Apr 23, 2020
8. fanquake added this to the milestone 0.20.0 on Apr 23, 2020
9. Fix naming of macOS SDK and clarify version

   Github-Pull: #18589
   Rebased-From: eb37275a6f972c81caef010b4ee9c5dc88edc759

   a9ca65bd29
10. hebasto approved
11. 
    hebasto commented at 2:03 AM on April 27, 2020: member

    ACK a9ca65bd29d5da63ade1e7995ec121a581ca7b17, locally backported and got zero diff with this PR.

12. 
    MarcoFalke commented at 6:11 PM on April 27, 2020: member

    There will be a few more backports, so I suggest piling them all up here and do one merge for rc2.

13. 
    fanquake commented at 11:23 PM on April 27, 2020: member

    There will be a few more backports, so I suggest piling them all up here

    That was the intent

14. rpc: Do not advertise dumptxoutset as a way to flush the chainstate

    Github-Pull: #18809
    Rebased-From: fac0cf6e5513df1402068df113d496b4e03a4bdc

    7f7548d822
15. 
    laanwj commented at 12:56 PM on May 11, 2020: member

    ACK 7f7548d822549579c57685c691e737f862b29e93

    It looks like 0.20.0 ran out of steam, to keep things moving a bit I'm going to merge this now.

16. laanwj merged this on May 11, 2020
17. laanwj closed this on May 11, 2020

    ---

18. DrahtBot locked this on Feb 15, 2022
19. fanquake deleted the branch on Aug 2, 2022

Milestone
0.20.0