test: Remove enumeration of expected deserialization exceptions in ProcessMessage(...) fuzzer #18757

pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:remove-EXPECTED_DESERIALIZATION_EXCEPTIONS changing 1 files +1 −23

practicalswift commented at 12:36 PM on April 24, 2020: contributor

Remove enumeration of expected deserialization exceptions in ProcessMessage(...) fuzzer.

Closes #18749.
fanquake added the label Tests on Apr 24, 2020
practicalswift renamed this:
~~tests: Remove enumeration of expected deserialization exceptions in ProcessMessage(...) fuzzer~~
test: Remove enumeration of expected deserialization exceptions in ProcessMessage(...) fuzzer
on Apr 24, 2020

in src/test/fuzz/process_message.cpp:80 in 36d169841d outdated

  77 | @@ -92,12 +78,6 @@ void test_one_input(const std::vector<uint8_t>& buffer)
  78 |      try {
  79 |          (void)ProcessMessage(&p2p_node, random_message_type, random_bytes_data_stream, GetTimeMillis(), Params(), *g_setup->m_node.mempool, g_setup->m_node.connman.get(), g_setup->m_node.banman.get(), std::atomic<bool>{false});
  80 |      } catch (const std::ios_base::failure& e) {

MarcoFalke commented at 12:38 PM on April 24, 2020:

    } catch (const std::ios_base::failure&) {

practicalswift commented at 12:44 PM on April 24, 2020:

Oh, fixed! Please re-review :)

MarcoFalke approved
MarcoFalke commented at 12:38 PM on April 24, 2020: member

ACK if travis passes
practicalswift force-pushed on Apr 24, 2020
fuzz: Remove enumeration of expected deserialization exceptions in ProcessMessage(...) fuzzer fdceb63283
practicalswift force-pushed on Apr 24, 2020
DrahtBot commented at 6:06 PM on April 24, 2020: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #18698 (Make g_chainman internal to validation by MarcoFalke)
- #18638 (net: Use mockable time for ping/pong, add tests by MarcoFalke)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
MarcoFalke merged this on Apr 24, 2020
MarcoFalke closed this on Apr 24, 2020
fanquake referenced this in commit 9a8fb4cf4b on May 15, 2020
deadalnix referenced this in commit b79b0f0bfa on Jan 22, 2021
backpacker69 referenced this in commit e4a4930ac1 on Mar 28, 2021
practicalswift deleted the branch on Apr 10, 2021
DrahtBot locked this on Aug 16, 2022

Contributors

Labels

Linked (view graph)

#18749 fuzz: libstdc++ vs libc++ iostream exception messages differ

test: Remove enumeration of expected deserialization exceptions in ProcessMessage(...) fuzzer #18757

Conflicts