bench: Start nodes with -nodebuglogfile #18759

For benchmarking we don't want to depend on the speed of the disk or the amount of debug logging

<!--e57a25ab6845829454e8d69fc972939a-->

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

<!--174a7506f384e20aa4161008e828411d-->

Conflicts

Reviewers, this pull request conflicts with the following ones:

• #18354 (Protect wallet by using shared pointers by bvbfan)
• #15719 (Drop Chain::requestMempoolTransactions method by ryanofsky)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

ACK fabe44e8154a6068d6cba91ec30f00345ed7b275 - This makes some of these benchmarks significantly faster to run. MempoolEviction total runtime is down from ~46s to 11s on my machine: master

git:(master) src/bench/bench_bitcoin --filter="AssembleBlock|DuplicateInputs|MempoolEviction|WalletBalance.*"
# Benchmark, evals, iterations, total, min, max, median
AssembleBlock, 5, 700, 1.96686, 0.000545187, 0.000587392, 0.000553906
DuplicateInputs, 5, 10, 0.465348, 0.00901881, 0.00985031, 0.00922294
MempoolEviction, 5, 41000, 46.2124, 0.000199084, 0.000236504, 0.000230176
WalletBalanceClean, 5, 8000, 2.51127, 6.08507e-05, 6.4575e-05, 6.30788e-05
WalletBalanceDirty, 5, 2500, 5.0095, 0.000393387, 0.000406474, 0.0004025
WalletBalanceMine, 5, 16000, 2.39288, 2.96132e-05, 3.06867e-05, 2.97721e-05
WalletBalanceWatch, 5, 8000, 2.41476, 5.97531e-05, 6.15939e-05, 6.022e-05

PR

git:(18759) src/bench/bench_bitcoin --filter="AssembleBlock|DuplicateInputs|MempoolEviction|WalletBalance.*"
# Benchmark, evals, iterations, total, min, max, median
AssembleBlock, 5, 700, 1.65915, 0.00046895, 0.000478331, 0.000476521
DuplicateInputs, 5, 10, 0.476503, 0.00940829, 0.0096428, 0.00954716
MempoolEviction, 5, 41000, 11.3648, 5.53623e-05, 5.55187e-05, 5.54437e-05
WalletBalanceClean, 5, 8000, 2.37871, 5.91818e-05, 5.97714e-05, 5.94537e-05
WalletBalanceDirty, 5, 2500, 4.63081, 0.000366719, 0.000372863, 0.000370887
WalletBalanceMine, 5, 16000, 2.3634, 2.94e-05, 2.9768e-05, 2.94947e-05
WalletBalanceWatch, 5, 8000, 2.39341, 5.96008e-05, 6.0065e-05, 5.98226e-05

Open-Close to re-run ci. See #15847 (comment)