qt: Close All Wallets menu option should be available #18845

issue brakmic opened this issue on May 1, 2020
  1. brakmic commented at 10:38 PM on May 1, 2020: contributor

    Currently, the File menu offers no option to close all loaded wallets at once.

    In cases where users have many (+5) wallets loaded, the usual...

    Open File Menu -> Select Close Wallet -> Answer MsgBox Question with YES

    ...can quickly become very unpleasant.

    Therefore, I'd recommend to implement a new menu option, Close All Wallets, that can:

    • Close all loaded wallets,
    • but still offers the do-you-want-to-close-this-wallet option, in cases where only certain wallets should be closed,
    • and is disabled, when there are no wallets loaded.

    UI

    close-all-wallets-menu-option

    close-all-wallets-automatically

    close-all-wallets-disabled

    Demo Code

    I have implemented a variant that's showcasing a possible solution, but because I:

    • don't know about possible reasons to not include an option like this
    • am not sure, if there are maybe similar solutions in the making (have checked commit history a bit, but not thorough enough to be sure)
    • would like to know how to make a proper Qt test for it, before making a PR out of it.

    Regards,

  2. brakmic added the label Feature on May 1, 2020
  3. fanquake commented at 12:52 AM on May 2, 2020: member

    This looks the same as #15202.

  4. hebasto commented at 3:24 AM on May 2, 2020: member

    This looks the same as #15202.

    While doing this, we should care about not creating new synchronous calls.

  5. brakmic commented at 8:05 AM on May 2, 2020: contributor

    This looks the same as #15202.

    Thanks, will then continue there.

  6. brakmic closed this on May 2, 2020

  7. promag commented at 12:11 AM on May 4, 2020: member

    @brakmic thanks, didn't update/push my PR due to some lack of interest but I'll do it shortly then.

    we should care about not creating new synchronous calls. @hebasto what do you mean?

  8. hebasto commented at 12:15 AM on May 4, 2020: member

    @promag

    we should care about not creating new synchronous calls.

    @hebasto what do you mean?

    I mean do not block/freeze the GUI :D

  9. DrahtBot locked this on Feb 15, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 15:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me