contrib: Move optimize-pngs.py script to the maintainer repo #18885

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2005-noOptPng changing 2 files +0 −82

MarcoFalke commented at 11:30 AM on May 5, 2020: member

Moved to https://github.com/bitcoin-core/bitcoin-maintainer-tools/blob/master/optimize-pngs.py

Bitcoin Core should focus on the full node implementation, not on scripts to compress png images.

This script is only used when new PNG files are added to the repo. This happens about once every two years. So fetching the script from the other repo should not be a burden, but removing it from this repo is going to cut down on the meta files we need to maintain in the main repo.

contrib: Remove optimize-pngs.py script, which lives in the maintainer repo

https://github.com/bitcoin-core/bitcoin-maintainer-tools/blob/master/optimize-pngs.py

fa13090d20

fanquake added the label Scripts and tools on May 5, 2020
practicalswift commented at 11:40 AM on May 5, 2020: contributor

Concept ACK
kristapsk commented at 11:50 AM on May 5, 2020: contributor

Concept ACK

I see the script differs little bit, that's some changes added on top?

Btw, here's script that copies file between two git repos preserving history. Doesn't work every time, but mostly do.
hebasto approved
hebasto commented at 11:56 AM on May 5, 2020: member

ACK fa13090d2048c9a1e475eb25de756763f8adddb8, verified that script is already moved.
practicalswift commented at 12:20 PM on May 5, 2020: contributor

ACK fa13090d2048c9a1e475eb25de756763f8adddb8 -- +0 lines, -82 lines :)
promag commented at 2:17 PM on May 5, 2020: member

ACK fa13090d2048c9a1e475eb25de756763f8adddb8.
MarcoFalke merged this on May 5, 2020
MarcoFalke closed this on May 5, 2020
MarcoFalke deleted the branch on May 5, 2020
sidhujag referenced this in commit 587b1ded46 on May 5, 2020
DrahtBot locked this on Feb 15, 2022

Contributors

Labels