qt: Reset toolbar after all wallets are closed #18896

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:200506-toolbar changing 1 files +1 −0

hebasto commented at 6:03 AM on May 6, 2020: member

If the last open wallet is closed from the non-"Overview" tab, that tab remains active when a new wallet is opened:

This PR fixes this bug.
fanquake added the label GUI on May 6, 2020

in src/qt/walletframe.cpp:99 in 7251b99309 outdated

  93 | @@ -94,6 +94,10 @@ void WalletFrame::removeWallet(WalletModel* wallet_model)
  94 |      WalletView *walletView = mapWalletViews.take(wallet_model);
  95 |      walletStack->removeWidget(walletView);
  96 |      delete walletView;
  97 | +
  98 | +    if (mapWalletViews.empty()) {
  99 | +        gui->gotoOverviewPage();

promag commented at 10:35 PM on May 6, 2020:

I'd avoid using gui, it should be unknown to WalletFrame - actually I have a branch to remove gui here. May I suggest to do this in BitcoinGUI::removeWallet, in m_wallet_selector->count() == 0 condition.

hebasto commented at 5:24 AM on May 7, 2020:

Updated.

promag commented at 10:38 PM on May 6, 2020: member

~~No strong opinion.~~ Concept ACK, it fixes the bug when a wallet is opened after closing the last one where the current page isn't overview.
qt: Reset toolbar after all wallets are closed 1e9bfd4926
hebasto force-pushed on May 7, 2020
hebasto commented at 5:23 AM on May 7, 2020: member
Updated 7251b993093730f965f9de5b1c45fe3238e2dfd9 -> 1e9bfd4926a3cbb9db877c773a60b0bbbbe8bde0 (pr18896.01 -> pr18896.02, diff):
- addressed @promag's comment
jonasschnelli commented at 7:41 AM on May 7, 2020: contributor

utACK 1e9bfd4926a3cbb9db877c773a60b0bbbbe8bde0
hebasto closed this on Jun 2, 2020
hebasto reopened this on Jun 2, 2020
hebasto commented at 10:47 AM on June 2, 2020: member

Reopened to update Travis CI build list.
luke-jr commented at 6:34 PM on June 2, 2020: member

utACK 1e9bfd4926a3cbb9db877c773a60b0bbbbe8bde0
luke-jr referenced this in commit 56a1929069 on Jun 9, 2020
hebasto commented at 8:19 PM on July 6, 2020: member

@promag Mind re-reviewing this PR?
promag commented at 8:43 PM on July 6, 2020: member

Code review ACK 1e9bfd4926a3cbb9db877c773a60b0bbbbe8bde0.
fanquake merged this on Jul 9, 2020
fanquake closed this on Jul 9, 2020
hebasto deleted the branch on Jul 9, 2020
sidhujag referenced this in commit b821d9a89c on Jul 9, 2020
PastaPastaPasta referenced this in commit 87c114679a on Jun 27, 2021
PastaPastaPasta referenced this in commit 8514ac16d5 on Jun 28, 2021
PastaPastaPasta referenced this in commit 0424b9beba on Jun 29, 2021
Fabcien referenced this in commit d4c384d916 on Aug 31, 2021
DrahtBot locked this on Feb 15, 2022

Contributors

Labels