[0.20] Fix release tarball #18909

1. 
   luke-jr commented at 7:15 pm on May 7, 2020: member

   Includes parts of #18556, #18741, #18818, and #18902 needed to fix the release tarball for 0.20
2. DrahtBot added the label Build system on May 7, 2020
3. DrahtBot added the label Scripts and tools on May 7, 2020
4. DrahtBot added the label Tests on May 7, 2020
5. 
   hebasto commented at 4:27 am on May 8, 2020: member

   c474e46ae7604f9b6cf8801207300b81c97e0499: Mind adding the .sh extension to the make_release_tarball script name to make it available for lint-shell.sh?
6. 
   hebasto commented at 5:05 am on May 8, 2020: member

   e46e063562a433d8a3718036985e9008f6278bc0 Could consider an alternative approach https://github.com/bitcoin/bitcoin/pull/18349/commits/80190e7aeb7e730934271b03918640ec18a56dc5 that seems less hacky?
7. 
   hebasto commented at 5:06 am on May 8, 2020: member

   Concept ACK.
8. DrahtBot added the label Needs rebase on May 12, 2020
9. build: Drop make dist in gitian builds

   Github-Pull: #18556
   Rebased-From: 1362be044724bb49d785ca2e296a3b43343c1690

   5f699b5d41
10. refactor: Drop unused ${WRAP_DIR}/${HOST} directory

    This commit removes the directory that is no longer used since #16667.
    
    Github-Pull: #18556
    Rebased-From: 2aa48edec0101f8a77a2189244fc62722ff7a123

    b84e35a910
11. gitian: Limit sourced script to just assignments

    Previously, the sourced script would create the source tarball. Now, it
    only assigns variables and the source-ing script has more flexibility in
    determining what to do with these variables.
    
    See later commit showing how this flexibility is useful in our Guix
    builds.
    
    Github-Pull: #18741
    Rebased-From: 395c1137f630dc495ffb2752a23bc1dfd470ee53

    62f0d73dba
12. rel-builds: Specify core.abbrev for git-rev-parse

    Chose 12 because the kernel uses it:
    
      https://public-inbox.org/git/CA+55aFy0_pwtFOYS1Tmnxipw9ZkRNCQHmoYyegO00pjMiZQfbg@mail.gmail.com/raw
    
    And also because it's a nice number.
    
    Github-Pull: #18741
    Rebased-From: bfe1ba2f5b36056e0c41edf8206b93d3d83098df

    808aaf90f2
13. build: Abstract release tarball generation to a utility script make_release_tarball

    Github-Pull: #18818
    Rebased-From: 0ea34e7251ded519efeb0169653f2601f2b5658c (partial: gitian only)

    b14f463d39
14. build: Run autogen & distclean when generating source tarball

    Github-Pull: #18818
    Rebased-From: 3897f3a2ec077f2be8f0d08f28e79165a6cae6d4 (partial: gitian only)

    cc4bb33890
15. Bugfix: Only use git for build info if the repository is actually the right one

    Original-Github-Pull: #7522
    Rebased-From: e98e3dde6a976a2c8f266ee963d6931fd4b37262 e98e3dde6a976a2c8f266ee963d6931fd4b37262
    
    Github-Pull: #18902
    Rebased-From: d9505bb8f88d7e9d83dc2895256f8ad2b0d6e7f0

    eee88e3356
16. build: Include tag name in release tarball for build.h

    Github-Pull: #18902
    Rebased-From: 83ecd1b15e81f53a373366200706325432b4f94f

    f9232da7ea
17. luke-jr force-pushed on May 14, 2020
18. DrahtBot removed the label Needs rebase on May 14, 2020
19. 
    fanquake commented at 5:59 am on April 8, 2021: member

    I’m going to close this. At this point we’re not going to be backporting any tarball related changes to the 0.20 branch. I’ll also echo the comments made in #18818; I haven’t seen a single complaint/issue related to changes in the 0.20 tarball over the ~10 months since it’s been released.
20. fanquake closed this on Apr 8, 2021

    ---

21. DrahtBot locked this on Aug 16, 2022

Contributors
luke-jr hebasto fanquake

Labels
Build system Tests Scripts and tools