net: use CMessageHeader::HEADER_SIZE, add missing include #18931

pull jonatack wants to merge 1 commits into bitcoin:master from jonatack:netcpp-use-CMessageHeader_HEADER_SIZE changing 1 files +3 −2

jonatack commented at 2:02 PM on May 10, 2020: member

as suggested 16 months ago by Gleb Naumenko in #15197 (comment).

static constexpr CMessageHeader::HEADER_SIZE is already used in this file, src/net.cpp, in 2 instances. This commit replaces the remaining 2 integer values in the file with it and adds the explicit include header.

Co-authored by: Gleb Naumenko naumenko.gs@gmail.com

net: use CMessageHeader::HEADER_SIZE, add missing include

static constexpr CMessageHeader::HEADER_SIZE is already used in this file,
src/net.cpp, in 2 instances. This commit replaces the remaining 2 integer
values with it and adds the explicit include header.

Co-authored by: Gleb Naumenko <naumenko.gs@gmail.com>

83da576f44

DrahtBot added the label P2P on May 10, 2020
theStack approved
theStack commented at 5:27 PM on May 10, 2020: member

ACK 83da576f4416c64b5d520819208a722b2273739a -- verified that its just magic number elimination refactoring and additionally checked that all tests pass :+1:
practicalswift commented at 5:59 PM on May 10, 2020: contributor

ACK 83da576f4416c64b5d520819208a722b2273739a -- patch looks correct
DrahtBot commented at 9:37 PM on May 10, 2020: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #18450 (util: Use locale independent ToString(…) instead of locale dependent strprintf(…) for low-level string formatting by practicalswift)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
naumenkogs commented at 3:25 PM on May 11, 2020: member

utACK 83da576
fanquake merged this on May 12, 2020
fanquake closed this on May 12, 2020
jonatack deleted the branch on May 12, 2020
sidhujag referenced this in commit 41ee04fed3 on May 12, 2020
Fabcien referenced this in commit 52644a5e02 on Jan 28, 2021
ftrader referenced this in commit be0453753c on Apr 14, 2021
DrahtBot locked this on Feb 15, 2022

Contributors

Labels

Linked (view graph)

#15197 Refactor and slightly stricter p2p message processing

net: use CMessageHeader::HEADER_SIZE, add missing include #18931

Conflicts