Assertion failed! rpcwallet.cpp Line 3838 #18944

Im on W10 x64 using the GUI. I'm syncing, the wallet is key disabled and it has 30k address watch only, all these are segwit p2sh. When I execute the rpc command getaddressesbylabel "" I get the following error message

If I click Anular , bitcoin core crash If I click Omitir I get the rpc response: { "": { "purpose": "unknown" }, "": { "purpose": "unknown" } }

It looks like you have duplicated addresses in your wallet.

// CWallet::mapAddressBook is not expected to contain duplicate
// address strings, but build a separate set as a precaution just in
// case it does.
bool unique = addresses.emplace(address).second;

How did you import the addresses/scripts?

For reference, this is the code:

https://github.com/bitcoin/bitcoin/blob/v0.19.1/src/wallet/rpcwallet.cpp#L3828-L3845

https://github.com/bitcoin/bitcoin/blob/58ba7c314d552cea8cb024960a8504577aee586f/src/wallet/rpcwallet.cpp#L3828-L3845

It looks like you have duplicated addresses in your wallet.

// CWallet::mapAddressBook is not expected to contain duplicate
// address strings, but build a separate set as a precaution just in
// case it does.
bool unique = addresses.emplace(address).second;

How did you import the addresses/scripts?

I imported it with importMulti , but maybe ran it multiple times, how I could check it? Anyways, if you import again the same address or privkey, bitcoin core shouldn't add it again if it is already in the wallet

Looking at the code #18944 (comment), it seems like this should only happen if there are two CTxDestination objects that don't compare equal but do have the same EncodeDestination string representation. Am I misreading or is the something known to happen?

I created a new wallet with these 30k address and I can correctly run the rpc command, but IDK why could be repeated address or keys in a wallet file created with same bitcoin core

@ryanofsky This happens at least in the case of two malformed WitnessUnknown and/or a CTxNoDestination, right?

All of them map to an empty string

Though, it should be impossible to import malformed WitnessUnknown, see #18974

Could this be caused by a corrupted bdb file?

I think this issue can be closed. In addition to #18974 the assertion has been replaced with a much safer check:

https://github.com/bitcoin/bitcoin/blob/d4ebdceaef130e4b68e5d5db67eecfefd24b4239/src/wallet/rpc/addresses.cpp#L668-L674

yeah, CHECK_NONFATAL doesn't crash the program, but it also aborts the current RPC

It would be good to know if this is still an issue with a recent version of Bitcoin Core?

This is no longer an issue in recent versions of Bitcoin Core. We'll close it for now, please feel free to add additional comments or open a new issue if you think that would be helpful.