rpcwallet: Replace boost::optional::emplace with simple assignment of T{} #18946

1. 
   MarcoFalke commented at 2:01 pm on May 11, 2020: member

   Closes #18943
2. rpcwallet: Replace boost::optional<T>::emplace with simple assignment of T{}

   Optional::emplace() was only added in boost 1.56, see
   https://github.com/boostorg/optional/commit/2e583aaf30964afd66c1284aa71d0d8b42fa440d
   
   To simply work around https://github.com/bitcoin/bitcoin/issues/18943,
   replace it with assignment of T{}

   fa182a8794
3. rpcwallet: Replace pwallet-> with wallet.

   pwallet is never null everywhere where it is dereferenced, so simply
   replace it with a reference, which can not be null by definition.

   fa1f840596
4. MarcoFalke added the label Refactoring on May 11, 2020
5. MarcoFalke added the label Wallet on May 11, 2020
6. MarcoFalke added this to the milestone 0.20.1 on May 11, 2020
7. MarcoFalke removed this from the milestone 0.20.1 on May 11, 2020
8. MarcoFalke added this to the milestone 0.20.1 on May 11, 2020
9. MarcoFalke removed this from the milestone 0.20.1 on May 11, 2020
10. MarcoFalke added this to the milestone 0.21.0 on May 11, 2020
11. ryanofsky approved
12. 
    ryanofsky commented at 2:59 pm on May 11, 2020: member

    Code review ACK fa1f840596554ed264d11ee3b3643bf99eb57eb5 and thanks for using a standalone commit for the fix
13. 
    DrahtBot commented at 6:06 pm on May 11, 2020: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #18734 (Allow simple multiwallet rpc calls by jonasschnelli)
    • #18531 (rpc: Assert that RPCArg names are equal to CRPCCommand ones by MarcoFalke)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

14. 
    promag commented at 6:26 pm on May 11, 2020: member

    Code review ACK fa1f840596554ed264d11ee3b3643bf99eb57eb5.
15. hebasto approved
16. 
    hebasto commented at 2:32 pm on May 14, 2020: member

    ACK fa1f840596554ed264d11ee3b3643bf99eb57eb5, tested on Linux Mint 19.3.
17. 
    laanwj commented at 5:25 pm on May 14, 2020: member

    ACK fa1f840596554ed264d11ee3b3643bf99eb57eb5
18. laanwj merged this on May 14, 2020
19. laanwj closed this on May 14, 2020

    ---

20. MarcoFalke deleted the branch on May 14, 2020
21. sidhujag referenced this in commit 81b853d60d on May 17, 2020
22. deadalnix referenced this in commit 430c7599fc on Jan 29, 2021
23. DrahtBot locked this on Feb 15, 2022

Contributors
MarcoFalke ryanofsky DrahtBot promag hebasto laanwj

Labels
Refactoring Wallet

Milestone
0.21.0