test: avoid os-dependant path #18952

The current code fails on windows because of the forward slashes; using os.path.join solves the problem and it is in general more robust

@sipsorcery want to take a look here & confirm the fix for windows?

Hmm Windows should typically be able to deal with / paths. Maybe it's a Python on Windows problem. I'll verify.

Jup, I don't think this is a bug fix. We've been running the functional tests on windows just fine.

FWIW, In the future if we really want to be have the slashes agnostic, we can use pathlib.Path which overrides the Div operator to insert slashes so you could do: Path(some_path) / 'src' / 'bitcoind'.

https://docs.python.org/3/library/pathlib.html

I like using os.path.join here (it's consistent—what we use in other places too). But yes, please change the motivation if it's a refactor not a fix.

I can verify that the current test_framework.py on master doesn't have any path issues when run on Windows.

It's hard to see where it could ever become a problem since modern day Windows accepts / as an alternative path separator.

The command below works fine on my Windows 10 machine:

cd c:/dev\github/sipsorcery_bitcoin//build_msvc

I import the test suite code in another project to automate regtest testing: when looking for the bitcoind binary on a Windows 10 machine, Python 3.8.2, no WSL, the original code fails. Also, just two lines below the code is using os.path.join, so consistency is lacking

ACK 8a22fd01140bd957036fc00419b147e4268ae9b1