test: Remove const to work around compiler error on xenial #18975

1. 
   laanwj commented at 4:42 PM on May 14, 2020: member

   Fix the following error in travis:

   test/validationinterface_tests.cpp:26:36: error: default initialization of an object of const type 'const BlockValidationState' without a user-provided default constructor
   
   const BlockValidationState state_dummy;

2. test: Remove const to work around compiler error on xenial

   Fix the following error in travis:
   
       test/validationinterface_tests.cpp:26:36: error: default initialization of an object of const type 'const BlockValidationState' without a user-provided default constructor
   
       const BlockValidationState state_dummy;

   050e2ee6f2
3. laanwj added the label Tests on May 14, 2020
4. 
   MarcoFalke commented at 4:57 PM on May 14, 2020: member

   Tested ACK 050e2ee6f28e7b31c167013be7313726e34084e9 on xenial with clang version 3.8.0-2ubuntu4 (tags/RELEASE_380/final)

5. MarcoFalke added the label Needs backport (0.20) on May 14, 2020
6. MarcoFalke added this to the milestone 0.20.0 on May 14, 2020
7. 
   fanquake commented at 11:54 PM on May 14, 2020: member

   ACK 050e2ee6f28e7b31c167013be7313726e34084e9 - I see why we didn't hit this on master. We are installing the clang-8 packages for the tsan job. However on the 0.20 branch we are still just installing clang, which is 3.8.

8. fanquake merged this on May 15, 2020
9. fanquake closed this on May 15, 2020

   ---

10. fanquake referenced this in commit cf2a6e2a39 on May 15, 2020
11. fanquake removed the label Needs backport (0.20) on May 15, 2020
12. MarcoFalke referenced this in commit 17bdf2afae on May 15, 2020
13. Fabcien referenced this in commit 7e535aabd8 on Feb 1, 2021
14. backpacker69 referenced this in commit 663989eefe on Mar 28, 2021
15. DrahtBot locked this on Feb 15, 2022

Milestone
0.20.0