build: Decouple clientversion.cpp from the git repo #18980

1. 
   hebasto commented at 6:44 am on May 15, 2020: member

   This PR makes build process not using git to get the client version from the repository. clientversion.cpp uses the client version data that are explicitly provided in configure.ac.

   gitian/guix builds are not touched yet.

   Alternative to #18902.

   Seeking for concept acks.

2. fanquake added the label Build system on May 15, 2020
3. 
   laanwj commented at 6:48 am on May 15, 2020: member

   Concept ACK. I like how this simplifies things.

   As I noted on IRC, all the version information for releases including the RC level is self-contained in configure.ac now. There’s no need to peek into git. Releases are built from a tag and every tag needs to have unique major/minor/build/rc numbers anyhow. Furthermore, my make-tag script verifies that these numbers match before making and signing the tag.

   There is one time it’s useful to look at git during the build process: if someone builds from git source, to be able to see the commit they built from in the program. This is somewhat useful for developers but if it causes too much difficulty and complexity (how many times has then been ‘fixed’ throughout Bitcoin Core’s history?) I’m okay with foregoing it.

4. 
   DrahtBot commented at 7:07 am on May 15, 2020: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #20223 (Drop the leading 0 from the version number by achow101)
   • #19160 (multiprocess: Add basic spawn and IPC support by ryanofsky)
   • #18902 (Bugfix: Only use git for build info if the repository is actually the right one by luke-jr)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

5. 
   tryphe commented at 5:32 am on May 17, 2020: contributor

   Concept ACK. Since we’re already using ac defines, one less script and one less header looks delicious!
6. DrahtBot added the label Needs rebase on May 21, 2020
7. build: Decouple clientversion.cpp from git repo 29990a5af9
8. build: Drop share/genbuild.sh 9e8a1d002e
9. hebasto force-pushed on May 22, 2020
10. 
    hebasto commented at 5:27 am on May 22, 2020: member

    Rebased f04a6b4e3db133a29221ba4830daaa5a58992911 -> 9e8a1d002edee6d1d3529832be304e16b4c6e497 (pr18980.01 -> pr18980.02) due to the conflict with #18677.
11. DrahtBot removed the label Needs rebase on May 22, 2020
12. laanwj requested review from dongcarl on May 28, 2020
13. laanwj requested review from theuni on May 28, 2020
14. 
    luke-jr commented at 2:59 pm on October 12, 2020: member

    Doesn’t this break including the current commit hash when doing actual git builds?
15. 
    DrahtBot commented at 3:49 pm on November 20, 2020: contributor

    🐙 This pull request conflicts with the target branch and needs rebase.

    Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a “draft”.

16. DrahtBot added the label Needs rebase on Nov 20, 2020
17. fanquake added the label Waiting for author on May 31, 2021
18. 
    fanquake commented at 7:06 am on May 31, 2021: member

    Concept ACK
19. MarcoFalke removed the label Waiting for author on May 31, 2021
20. 
    DrahtBot commented at 11:21 am on December 15, 2021: contributor

    • Is it still relevant? ➡️ Please solve the conflicts to make it ready for review and to ensure the CI passes.
    • Is it no longer relevant? ➡️ Please close.
    • Did the author lose interest or time to work on this? ➡️ Please close it and mark it ‘Up for grabs’ with the label, so that it can be picked up in the future.
21. 
    fanquake commented at 10:17 am on October 3, 2022: member

    Changing my concept ACK to ~0. It’s not clear the tradeoff of losing git info from source builds is worth this change, and for some reason that tradeoff isn’t mentioned in the PR description.

    Otherwise, what is the status of this?

22. hebasto closed this on Oct 5, 2022

    ---

23. bitcoin locked this on Oct 5, 2023

Contributors
hebasto laanwj DrahtBot tryphe luke-jr fanquake

Review Requested
theuni dongcarl

Labels
Build system Needs rebase