fix #17969 and also add better messages to AddressBookPage when it's called from SignVerifyMessageDialog
qt: AddressBookPage - Hide non PKHash-Addresses and improve GUI messages for signing address book #18992
pull 10xcryptodev wants to merge 1 commits into bitcoin:master from 10xcryptodevforks:202005-sign-message-ui changing 3 files +37 −8-
10xcryptodev commented at 3:09 AM on May 17, 2020: contributor
- fanquake added the label GUI on May 17, 2020
-
DrahtBot commented at 3:30 AM on May 17, 2020: member
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #17918 (qt: Hide non PKHash-Addresses in signing address book by emilengler)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
-
qt: add sign and verify message support to AddressBookPage 4889b8f774
- 10xcryptodev force-pushed on May 17, 2020
- DrahtBot added the label Needs rebase on May 29, 2020
-
DrahtBot commented at 9:49 AM on May 29, 2020: member
<!--cf906140f33d8803c4a75a2196329ecb-->
🐙 This pull request conflicts with the target branch and needs rebase.
-
10xcryptodev commented at 8:47 PM on May 30, 2020: contributor
#17918 doesn't solve the GUI messages on AddressBookPage for sign and verify case, when the user open the dialog from sign and verify message. Also modify walletmodel that's not necessary. @jonasschnelli could you take a look on this solution?
-
jonasschnelli commented at 8:39 AM on May 31, 2020: contributor
Concept ACK. Will have a closer look soon.
-
luke-jr commented at 8:26 PM on June 2, 2020: member
PR title is confusing.
- 10xcryptodev renamed this:
qt: add sign and verify message support to AddressBookPage
qt: AddressBookPage - Hide non PKHash-Addresses and improve GUI messages for signing address book
on Jun 3, 2020 -
10xcryptodev commented at 3:49 AM on June 3, 2020: contributor
@luke-jr hope it's better now, i'm not so good with PR titles :)
Giving more details here: I implemented your suggestion: https://github.com/bitcoin/bitcoin/pull/17918/files#r371023931
Working on that solution i also found the AddressBookPage was using the GUI messages for
SendingTabandReceivingTabshowing wrong messages and window title for the user, also fixed that -
fanquake commented at 12:24 AM on August 15, 2020: member
@10xcryptodev Can you reopen this PR over in the new GUI repo?
- fanquake closed this on Aug 15, 2020
-
10xcryptodev commented at 8:38 PM on August 16, 2020: contributor
@fanquake sure, i will open in the repo, thanks
- fanquake removed the label Needs rebase on May 31, 2021
- DrahtBot locked this on Aug 18, 2022
